From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753531AbcDASoy (ORCPT ); Fri, 1 Apr 2016 14:44:54 -0400 Received: from smtprelay0115.hostedemail.com ([216.40.44.115]:45632 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751834AbcDASow (ORCPT ); Fri, 1 Apr 2016 14:44:52 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:967:968:973:982:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1373:1431:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2525:2553:2561:2564:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3354:3622:3770:3865:3866:3867:3868:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:4659:5007:6120:7514:7809:7875:8599:9025:10004:10400:10450:10455:10848:11232:11257:11658:11914:12043:12213:12292:12295:12517:12519:12555:12682:12740:13439:13845:13894:14181:14659:14721:19904:19999:21080:30003:30012:30022:30041:30054:30064:30070:30090:30091,0,RBL:error,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:error,Custom_rules:0:0:0,LFtime:2000,LUA_SUMMARY:none X-HE-Tag: wind54_292e28f192d62 X-Filterd-Recvd-Size: 3085 Message-ID: <1459536253.1744.26.camel@perches.com> Subject: Re: [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef From: Joe Perches To: "Drokin, Oleg" , James Simmons Cc: "" , Greg Kroah-Hartman , "" , "" Date: Fri, 01 Apr 2016 11:44:13 -0700 In-Reply-To: <0586F4EF-3E2B-419A-8343-3A4A7E34628D@intel.com> References: <0586F4EF-3E2B-419A-8343-3A4A7E34628D@intel.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-04-01 at 14:23 +0000, Drokin, Oleg wrote: > On Apr 1, 2016, at 9:02 AM, Joe Perches wrote: > > > > Question about removing lustre typedefs. > > > > Various bits of lustre code use a mix of struct foo and foo_t. > > > > When would be an appropriate time to submit patches similar to > > below that individually remove various typedefs from lustre code? > I think now is as good time as any. > the only small correction is those are LNet typedefs. > While LNet is technically part of Lustre, it's a bit of a separate > thing useful without Lustre too. > > I know James is working on cleaning up LNet, but I don't know if he has > anything this would be conflicting at this moment or not. > > Thanks for the patches. I wonder if you are generating them automatically? > Because it would be great if it also fixes the alignment issues It's pretty automatic. It's a trivial variant of the detypedef perl script I wrote awhile ago: http://permalink.gmane.org/gmane.linux.drivers.driver-project.devel/18603 I think changing the alignment issues is better done in a separate patch. James isn't cc'd on these patches as he's not a listed maintainer.  Maybe he should be added for all of it or some part of it? I don't know what email address James prefers as there are several in git log for him. James Simmons James Simmons James Simmons "Simmons, James A." but maybe something like this: ---  MAINTAINERS | 1 +  1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 16ccda4..d585631 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10578,6 +10578,7 @@ F: drivers/staging/media/lirc/  STAGING - LUSTRE PARALLEL FILESYSTEM  M: Oleg Drokin  M: Andreas Dilger +R: James Simmons  L: lustre-devel@lists.lustre.org (moderated for non-subscribers)  W: http://wiki.lustre.org/  S: Maintained From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Fri, 01 Apr 2016 11:44:13 -0700 Subject: [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef In-Reply-To: <0586F4EF-3E2B-419A-8343-3A4A7E34628D@intel.com> References: <0586F4EF-3E2B-419A-8343-3A4A7E34628D@intel.com> Message-ID: <1459536253.1744.26.camel@perches.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Drokin, Oleg" , James Simmons Cc: "" , Greg Kroah-Hartman , "" , "" On Fri, 2016-04-01 at 14:23 +0000, Drokin, Oleg wrote: > On Apr 1, 2016, at 9:02 AM, Joe Perches wrote: > > > > Question about removing lustre typedefs. > > > > Various bits of lustre code use a mix of struct foo and foo_t. > > > > When would be an appropriate time to submit patches similar to > > below that individually remove various typedefs from lustre code? > I think now is as good time as any. > the only small correction is those are LNet typedefs. > While LNet is technically part of Lustre, it's a bit of a separate > thing useful without Lustre too. > > I know James is working on cleaning up LNet, but I don't know if he has > anything this would be conflicting at this moment or not. > > Thanks for the patches. I wonder if you are generating them automatically? > Because it would be great if it also fixes the alignment issues It's pretty automatic. It's a trivial variant of the detypedef perl script I wrote awhile ago: http://permalink.gmane.org/gmane.linux.drivers.driver-project.devel/18603 I think changing the alignment issues is better done in a separate patch. James isn't cc'd on these patches as he's not a listed maintainer. ?Maybe he should be added for all of it or some part of it? I don't know what email address James prefers as there are several in git log for him. James Simmons James Simmons James Simmons "Simmons, James A." but maybe something like this: --- ?MAINTAINERS | 1 + ?1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 16ccda4..d585631 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10578,6 +10578,7 @@ F: drivers/staging/media/lirc/ ?STAGING - LUSTRE PARALLEL FILESYSTEM ?M: Oleg Drokin ?M: Andreas Dilger +R: James Simmons ?L: lustre-devel at lists.lustre.org (moderated for non-subscribers) ?W: http://wiki.lustre.org/ ?S: Maintained