From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754327AbcDAT14 (ORCPT ); Fri, 1 Apr 2016 15:27:56 -0400 Received: from smtprelay0014.hostedemail.com ([216.40.44.14]:50155 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750938AbcDAT1z (ORCPT ); Fri, 1 Apr 2016 15:27:55 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:967:968:973:982:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2525:2553:2560:2563:2682:2685:2828:2859:2915:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6119:6120:7903:7974:8599:9025:10004:10400:10450:10455:10848:11232:11658:11914:12043:12295:12517:12519:12555:12740:13069:13311:13357:13439:14094:14096:14181:14659:14721:19904:19999:21080:30012:30041:30054:30064:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: team23_7f03de6c6c300 X-Filterd-Recvd-Size: 2804 Message-ID: <1459538843.1744.34.camel@perches.com> Subject: Re: [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef From: Joe Perches To: "Drokin, Oleg" Cc: James Simmons , "" , Greg Kroah-Hartman , "" , "" Date: Fri, 01 Apr 2016 12:27:23 -0700 In-Reply-To: <46D8C648-9F97-4D8D-B869-055B81A5E1EE@intel.com> References: <0586F4EF-3E2B-419A-8343-3A4A7E34628D@intel.com> <1459536253.1744.26.camel@perches.com> <46D8C648-9F97-4D8D-B869-055B81A5E1EE@intel.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-04-01 at 19:14 +0000, Drokin, Oleg wrote: > On Apr 1, 2016, at 2:44 PM, Joe Perches wrote: > > On Fri, 2016-04-01 at 14:23 +0000, Drokin, Oleg wrote: > > > On Apr 1, 2016, at 9:02 AM, Joe Perches wrote: > > > > Question about removing lustre typedefs. > > > > > > > > Various bits of lustre code use a mix of struct foo and foo_t. > > > > > > > > When would be an appropriate time to submit patches similar to > > > > below that individually remove various typedefs from lustre code? > > > I think now is as good time as any. > > > the only small correction is those are LNet typedefs. > > > While LNet is technically part of Lustre, it's a bit of a separate > > > thing useful without Lustre too. > > > > > > I know James is working on cleaning up LNet, but I don't know if he has > > > anything this would be conflicting at this moment or not. > > > > > > Thanks for the patches. I wonder if you are generating them automatically? > > > Because it would be great if it also fixes the alignment issues > > It's pretty automatic. > > > > It's a trivial variant of the detypedef perl script I wrote awhile ago: > > http://permalink.gmane.org/gmane.linux.drivers.driver-project.devel/18603 > > > > I think changing the alignment issues is better done in a > > separate patch. > but then it's two patches per change in a way. fixing one thing breaking > the other warning-wise, that's why I typically try to make such cleanup > patches not to introduce any new warnings. detypedef frequently introduces > 80 column lines. It's much easier to verify this way without introducing changes like rewrapping to 80 column. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Fri, 01 Apr 2016 12:27:23 -0700 Subject: [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef In-Reply-To: <46D8C648-9F97-4D8D-B869-055B81A5E1EE@intel.com> References: <0586F4EF-3E2B-419A-8343-3A4A7E34628D@intel.com> <1459536253.1744.26.camel@perches.com> <46D8C648-9F97-4D8D-B869-055B81A5E1EE@intel.com> Message-ID: <1459538843.1744.34.camel@perches.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Drokin, Oleg" Cc: James Simmons , "" , Greg Kroah-Hartman , "" , "" On Fri, 2016-04-01 at 19:14 +0000, Drokin, Oleg wrote: > On Apr 1, 2016, at 2:44 PM, Joe Perches wrote: > > On Fri, 2016-04-01 at 14:23 +0000, Drokin, Oleg wrote: > > > On Apr 1, 2016, at 9:02 AM, Joe Perches wrote: > > > > Question about removing lustre typedefs. > > > > > > > > Various bits of lustre code use a mix of struct foo and foo_t. > > > > > > > > When would be an appropriate time to submit patches similar to > > > > below that individually remove various typedefs from lustre code? > > > I think now is as good time as any. > > > the only small correction is those are LNet typedefs. > > > While LNet is technically part of Lustre, it's a bit of a separate > > > thing useful without Lustre too. > > > > > > I know James is working on cleaning up LNet, but I don't know if he has > > > anything this would be conflicting at this moment or not. > > > > > > Thanks for the patches. I wonder if you are generating them automatically? > > > Because it would be great if it also fixes the alignment issues > > It's pretty automatic. > > > > It's a trivial variant of the detypedef perl script I wrote awhile ago: > > http://permalink.gmane.org/gmane.linux.drivers.driver-project.devel/18603 > > > > I think changing the alignment issues is better done in a > > separate patch. > but then it's two patches per change in a way. fixing one thing breaking > the other warning-wise, that's why I typically try to make such cleanup > patches not to introduce any new warnings. detypedef frequently introduces > 80 column lines. It's much easier to verify this way without introducing changes like rewrapping to 80 column.