All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Covington <cov@codeaurora.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-serial@vger.kernel.org
Cc: Andre Przywara <andre.przywara@arm.com>,
	Russell King <linux@arm.linux.org.uk>,
	Dave Martin <dave.martin@arm.com>,
	Jim Perrin <jperrin@centos.org>, Jon Masters <jcm@redhat.com>,
	Mark Langsdorf <mlangsdo@redhat.com>,
	Mark Salter <msalter@redhat.com>,
	Timur Tabi <timur@codeaurora.org>,
	Aleksey Makarov <aleksey.makarov@linaro.org>,
	Christopher Covington <cov@codeaurora.org>,
	Jiri Slaby <jslaby@suse.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3] tty: amba-pl011: Use 32-bit accesses for SBSA UART
Date: Fri,  1 Apr 2016 17:23:58 -0400	[thread overview]
Message-ID: <1459545838-17646-1-git-send-email-cov@codeaurora.org> (raw)
In-Reply-To: <20160330165551.GB23817@kroah.com>

Version 2 of the Server Base System Architecture (SBSAv2) describes UART
hardware registers as 32 bits wide, giving no guidance on access sizes. The
SBSA UART driver previously assumed partial-length 16 and 8 bit accesses would
work. But the SBSAv2 UART hardware on the Qualcomm Technologies QDF2432 only
supports full-length 32 bit register accesses, so use those exclusively. This
is compatible with SBSAv3, which explicitly requires UART hardware support 32
(and 16 and sometimes 8) bit accesses.

Tested on Juno, Midway, QDF2432, Seattle, and X-Gene 1.

Tested-by: Mark Langsdorf <mlangsdo@redhat.com>
Tested-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Christopher Covington <cov@codeaurora.org>
---
Changes since v2:
* Updated commit message
* Added Andre's Acked-by and Tested-by.
---
 drivers/tty/serial/amba-pl011.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
index 7c198e0..a2aa655 100644
--- a/drivers/tty/serial/amba-pl011.c
+++ b/drivers/tty/serial/amba-pl011.c
@@ -121,6 +121,7 @@ static struct vendor_data vendor_arm = {
 
 static struct vendor_data vendor_sbsa = {
 	.reg_offset		= pl011_std_offsets,
+	.access_32b		= true,
 	.oversampling		= false,
 	.dma_threshold		= false,
 	.cts_event_workaround	= false,
-- 
Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

      parent reply	other threads:[~2016-04-01 21:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08  5:43 [PATCH] tty: amba-pl011: Use 32-bit accesses for SBSA UART Christopher Covington
2016-03-08 14:51 ` Mark Langsdorf
2016-03-11  6:35 ` Christopher Covington
2016-03-11 15:02   ` Peter Hurley
2016-03-11 23:38     ` [PATCH v2] " Christopher Covington
2016-03-15 10:08   ` [PATCH] " Andre Przywara
2016-03-30 12:30     ` Christopher Covington
2016-03-30 16:55       ` Greg Kroah-Hartman
2016-03-30 17:01         ` Timur Tabi
2016-03-30 18:01           ` Greg Kroah-Hartman
2016-03-30 18:11             ` Timur Tabi
2016-04-01 21:23         ` Christopher Covington [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459545838-17646-1-git-send-email-cov@codeaurora.org \
    --to=cov@codeaurora.org \
    --cc=aleksey.makarov@linaro.org \
    --cc=andre.przywara@arm.com \
    --cc=dave.martin@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jcm@redhat.com \
    --cc=jperrin@centos.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mlangsdo@redhat.com \
    --cc=msalter@redhat.com \
    --cc=timur@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.