All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grigori Goronzy <greg@chown.ath.cx>
To: Johan Hovold <johan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Grigori Goronzy <greg@chown.ath.cx>
Subject: [PATCH v2 13/14] USB: ch341: get rid of default configuration
Date: Sat,  2 Apr 2016 19:07:22 +0200	[thread overview]
Message-ID: <1459616843-23829-14-git-send-email-greg@chown.ath.cx> (raw)
In-Reply-To: <1459616843-23829-1-git-send-email-greg@chown.ath.cx>

If the serial port hasn't been opened yet, no baud rate should be
set and RTS/DTR need to be deasserted.

Signed-off-by: Grigori Goronzy <greg@chown.ath.cx>
---
 drivers/usb/serial/ch341.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index 3b9a43d..6981e2ad 100644
--- a/drivers/usb/serial/ch341.c
+++ b/drivers/usb/serial/ch341.c
@@ -25,7 +25,6 @@
 #include <linux/serial.h>
 #include <asm/unaligned.h>
 
-#define DEFAULT_BAUD_RATE 9600
 #define DEFAULT_TIMEOUT   1000
 
 /* flags for IO-Bits */
@@ -235,10 +234,6 @@ static int ch341_configure(struct usb_device *dev, struct ch341_private *priv)
 	if (r < 0)
 		goto out;
 
-	r = ch341_init_set_baudrate(dev, priv, 0);
-	if (r < 0)
-		goto out;
-
 	r = ch341_set_handshake(dev, priv->line_control);
 	if (r < 0)
 		goto out;
@@ -261,8 +256,6 @@ static int ch341_port_probe(struct usb_serial_port *port)
 		return -ENOMEM;
 
 	spin_lock_init(&priv->lock);
-	priv->baud_rate = DEFAULT_BAUD_RATE;
-	priv->line_control = CH341_BIT_RTS | CH341_BIT_DTR;
 
 	r = ch341_configure(port->serial->dev, priv);
 	if (r < 0)
-- 
1.9.1

  parent reply	other threads:[~2016-04-02 17:17 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-02 17:07 Major improvements to the ch341 driver Grigori Goronzy
2016-04-02 17:07 ` [PATCH v2 01/14] USB: ch341: improve documentation Grigori Goronzy
2016-04-06 11:58   ` One Thousand Gnomes
2016-04-02 17:07 ` [PATCH v2 02/14] USB: ch341: fix error handling on resume Grigori Goronzy
2016-04-02 17:07 ` [PATCH v2 03/14] USB: ch341: add LCR register definitions Grigori Goronzy
2016-04-02 17:07 ` [PATCH v2 04/14] USB: ch341: add definitions for modem control Grigori Goronzy
2016-04-02 17:07 ` [PATCH v2 05/14] USB: ch341: fix USB buffer allocations Grigori Goronzy
2016-04-04  7:13   ` Oliver Neukum
2016-04-02 17:07 ` [PATCH v2 06/14] USB: ch341: reinitialize chip on reconfiguration Grigori Goronzy
2016-04-10 13:24   ` Clemens Ladisch
2016-04-02 17:07 ` [PATCH v2 07/14] USB: ch341: add support for parity, frame length, stop bits Grigori Goronzy
2016-04-03 15:58   ` Karl Palsson
2016-04-06 11:59   ` One Thousand Gnomes
2016-04-02 17:07 ` [PATCH v2 08/14] USB: ch341: add debug output for chip version Grigori Goronzy
2016-04-02 17:07 ` [PATCH v2 09/14] USB: ch341: add support for RTS/CTS flow control Grigori Goronzy
2016-04-02 17:07 ` [PATCH v2 10/14] USB: ch341: fix coding style Grigori Goronzy
2016-04-02 17:29   ` Joe Perches
2016-04-06 17:58     ` Grigori Goronzy
2016-04-06 18:10       ` Johan Hovold
2016-04-07  1:11         ` Grigori Goronzy
2016-04-02 17:07 ` [PATCH v2 11/14] USB: ch341: clean up messages Grigori Goronzy
2016-04-02 17:07 ` [PATCH v2 12/14] USB: ch341: improve B0 handling Grigori Goronzy
2016-04-02 17:07 ` Grigori Goronzy [this message]
2016-04-02 17:07 ` [PATCH v2 14/14] USB: ch341: implement tx_empty callback Grigori Goronzy
2016-04-03 16:03   ` Karl Palsson
2016-04-06 18:03     ` Grigori Goronzy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459616843-23829-14-git-send-email-greg@chown.ath.cx \
    --to=greg@chown.ath.cx \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.