From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an6q0-0007aC-NK for qemu-devel@nongnu.org; Mon, 04 Apr 2016 11:54:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1an6px-0006nI-FT for qemu-devel@nongnu.org; Mon, 04 Apr 2016 11:54:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45329) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an6px-0006nC-AE for qemu-devel@nongnu.org; Mon, 04 Apr 2016 11:54:45 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 491A1804E4 for ; Mon, 4 Apr 2016 15:54:44 +0000 (UTC) From: "Dr. David Alan Gilbert (git)" Date: Mon, 4 Apr 2016 16:54:41 +0100 Message-Id: <1459785281-6686-1-git-send-email-dgilbert@redhat.com> Subject: [Qemu-devel] [PATCH] Migration: Add i82801b11 migration data List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, mst@redhat.com Cc: marcel@redhat.com, amit.shah@redhat.com, jsnow@redhat.com, quintela@redhat.com From: "Dr. David Alan Gilbert" The i82801b11 bridge didn't have a vmsd and thus didn't send any migration data, including that of its parent PCIBridge object. The symptom being if the guest used any devices behind the bridge the guest crashed (mostly with various interrupt related issues). Note: This will cause migration from old qemus that used this device to explicitly fail during migration as opposed to the guest crashing. Signed-off-by: Dr. David Alan Gilbert Suggested-by: Marcel Apfelbaum --- hw/pci-bridge/i82801b11.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/hw/pci-bridge/i82801b11.c b/hw/pci-bridge/i82801b11.c index 5c40708..2404e7e 100644 --- a/hw/pci-bridge/i82801b11.c +++ b/hw/pci-bridge/i82801b11.c @@ -78,6 +78,14 @@ err_bridge: return rc; } +static const VMStateDescription i82801b11_bridge_dev_vmstate = { + .name = "i82801b11_bridge", + .fields = (VMStateField[]) { + VMSTATE_PCI_DEVICE(parent_obj, PCIBridge), + VMSTATE_END_OF_LIST() + } +}; + static void i82801b11_bridge_class_init(ObjectClass *klass, void *data) { PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); @@ -89,6 +97,7 @@ static void i82801b11_bridge_class_init(ObjectClass *klass, void *data) k->revision = ICH9_D2P_A2_REVISION; k->init = i82801b11_bridge_initfn; k->config_write = pci_bridge_write_config; + dc->vmsd = &i82801b11_bridge_dev_vmstate; set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); } -- 2.5.5