From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754839AbcDDQTX (ORCPT ); Mon, 4 Apr 2016 12:19:23 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:36450 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495AbcDDQTW (ORCPT ); Mon, 4 Apr 2016 12:19:22 -0400 Message-ID: <1459786759.10375.2.camel@pengutronix.de> Subject: Re: [PATCH] reset: Add missing function stub for device_reset From: Philipp Zabel To: Daniel Lezcano Cc: matthias.bgg@gmail.com, open list Date: Mon, 04 Apr 2016 18:19:19 +0200 In-Reply-To: <1459539496-823-1-git-send-email-daniel.lezcano@linaro.org> References: <1459539496-823-1-git-send-email-daniel.lezcano@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, Am Freitag, den 01.04.2016, 21:38 +0200 schrieb Daniel Lezcano: > The Mediatek's thermal driver fails to compile when the RESET_CONTROLLER > option is not set. Logically, as the driver depends on this option to compile, > the Kconfig should select it but actually that is not correct because the > Kconfig provides also the COMPILE_TEST to increase the compile test coverage. > > By providing the missing 'device_reset' stub for the driver in reset.h, that > let the kernel to compile on different platforms with the Mediatek thermal > driver enabled with the COMPILE_TEST option. > > Signed-off-by: Daniel Lezcano > --- > include/linux/reset.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/reset.h b/include/linux/reset.h > index c4c097d..db8cd7b 100644 > --- a/include/linux/reset.h > +++ b/include/linux/reset.h > @@ -72,6 +72,11 @@ static inline void reset_control_put(struct reset_control *rstc) > WARN_ON(1); > } > > +static inline int __must_check device_reset(struct device *dev) > +{ + WARN_ON(1); > + return -ENOTSUPP; > +} > + > static inline int device_reset_optional(struct device *dev) > { > return -ENOTSUPP; Thank you, I've added the warning above and applied the patch. best regards Philipp