From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoCsK-0001J4-EG for qemu-devel@nongnu.org; Thu, 07 Apr 2016 12:33:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aoCsI-0005jV-Kr for qemu-devel@nongnu.org; Thu, 07 Apr 2016 12:33:44 -0400 Sender: Paolo Bonzini From: Paolo Bonzini Date: Thu, 7 Apr 2016 18:33:30 +0200 Message-Id: <1460046816-102846-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1460046816-102846-1-git-send-email-pbonzini@redhat.com> References: <1460046816-102846-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH v4 2/8] block: make bdrv_start_throttled_reqs return void List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, berto@igalia.com, famz@redhat.com, qemu-block@nongnu.org, stefanha@redhat.com The return value is unused and I am not sure why it would be useful. Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini --- block/io.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/block/io.c b/block/io.c index a91d862..691baa6 100644 --- a/block/io.c +++ b/block/io.c @@ -71,10 +71,8 @@ void bdrv_set_io_limits(BlockDriverState *bs, } } -/* this function drain all the throttled IOs */ -static bool bdrv_start_throttled_reqs(BlockDriverState *bs) +static void bdrv_start_throttled_reqs(BlockDriverState *bs) { - bool drained = false; bool enabled = bs->io_limits_enabled; int i; @@ -82,13 +80,11 @@ static bool bdrv_start_throttled_reqs(BlockDriverState *bs) for (i = 0; i < 2; i++) { while (qemu_co_enter_next(&bs->throttled_reqs[i])) { - drained = true; + ; } } bs->io_limits_enabled = enabled; - - return drained; } void bdrv_io_limits_disable(BlockDriverState *bs) -- 1.8.3.1