All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: "Bjørn Mork" <bjorn@mork.no>, "Daniel Borkmann" <daniel@iogearbox.net>
Cc: davem@davemloft.net, robbat2@gentoo.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ipv6, token: allow for clearing the current device token
Date: Fri, 08 Apr 2016 16:33:58 +0200	[thread overview]
Message-ID: <1460126038.1452331.572938089.68D8127C@webmail.messagingengine.com> (raw)
In-Reply-To: <878u0otc96.fsf@nemi.mork.no>



On Fri, Apr 8, 2016, at 16:18, Bjørn Mork wrote:
> Daniel Borkmann <daniel@iogearbox.net> writes:
> 
> >  
> >  	if (!token)
> >  		return -EINVAL;
> > -	if (ipv6_addr_any(token))
> > -		return -EINVAL;
> >  	if (dev->flags & (IFF_LOOPBACK | IFF_NOARP))
> >  		return -EINVAL;
> 
> Not directly related to the patch in question.  It just made me aware of
> this restriction...
> 
> I realize that I'm a few years late here, but what's with the IFF_NOARP?
> Is that just because we can't do DAD for the token based addresses?  How
> is that different from manually configuring the whole address?

IFF_NOARP is kind of the equivalent to no neighbor discovery. If you set
a token and never get in a router advertisement you never create a
tokenized ip address, thus the feature is useless.

Bye,
Hannes

  reply	other threads:[~2016-04-08 14:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08 13:55 [PATCH net-next] ipv6, token: allow for clearing the current device token Daniel Borkmann
2016-04-08 13:57 ` Hannes Frederic Sowa
2016-04-08 14:18 ` Bjørn Mork
2016-04-08 14:33   ` Hannes Frederic Sowa [this message]
2016-04-08 15:25     ` Bjørn Mork
2016-04-08 15:36       ` Hannes Frederic Sowa
2016-04-08 17:13         ` Daniel Borkmann
2016-04-14  2:43 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460126038.1452331.572938089.68D8127C@webmail.messagingengine.com \
    --to=hannes@stressinduktion.org \
    --cc=bjorn@mork.no \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=robbat2@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.