From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: sagig@mellanox.com, linux-rdma@vger.kernel.org,
target-devel@vger.kernel.org
Subject: Re: T10 PI offloading seems to be broken in iser/isert in 4.5/4.6-rc
Date: Fri, 08 Apr 2016 16:48:10 -0700 [thread overview]
Message-ID: <1460159290.901.5.camel@haakon3.risingtidesystems.com> (raw)
In-Reply-To: <20160408221553.GA3716@infradead.org>
On Fri, 2016-04-08 at 15:15 -0700, Christoph Hellwig wrote:
> Hi all,
>
> I've recently started looking into adding support for signature MRs
> in the RDMA R/W API, but it seems like it's already broken upstream.
>
> I suspect it's the target that's at fault, but I'm not sure. I've
> tested 4.5 and todays 4.6-rc tree on both the target and the client
> side.
>
> The setup is pretty simple: on the target I've loaded scsi_debug
> with dif=1 and dix=1, and set I've set fabric_prot_type=1, t10_pi=1
> and ImmediateData to No on the tpg, and then did a simple mkfs.ext4.
>
> Just doing the login I get the following error on the target:
>
> [ 369.890182] Bad block size given: 0
> [ 369.894131] mlx5_0:mlx5_ib_post_send:3296:(pid 331):
> [ 369.894228] isert: isert_reg_sig_mr: fast registration failed, ret:-22
> [ 369.901580] isert: isert_handle_prot_cmd: conn ffff880904d54000 failed to fast reg mr
> [ 369.906348] iSCSI/iqn.1993-08.org.debian:01:197dad5d1f17: Unsupported SCSI Opcode 0xa3, sending CHECK_CONDITION.
> [ 369.910395] isert: isert_put_datain: Cmd: ffff880902b26b00 failed to prepare RDMA res
>
> If I then do an actual I/O think go downhill quickly.
It looks like the isert_set_dif_domain() assignments of
ib_sig_domain->sig.dif.* from dev->dev_attrib.block_size + friends is
being zeroed before making it into mlx5_ib_post_send() ->
IB_WR_REG_SIG_MR -> set_sig_umr_wr() -> set_sig_data_segment().
next prev parent reply other threads:[~2016-04-08 23:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 22:15 T10 PI offloading seems to be broken in iser/isert in 4.5/4.6-rc Christoph Hellwig
2016-04-08 23:48 ` Nicholas A. Bellinger [this message]
2016-04-09 0:14 ` Christoph Hellwig
2016-04-09 2:36 ` Nicholas A. Bellinger
2016-04-09 4:58 ` Christoph Hellwig
[not found] ` <20160409045846.GA9269-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-04-10 8:53 ` Sagi Grimberg
2016-04-10 14:37 ` Christoph Hellwig
2016-04-10 15:30 ` Sagi Grimberg
[not found] ` <1460169374.5010.4.camel-XoQW25Eq2zviZyQQd+hFbcojREIfoBdhmpATvIKMPHk@public.gmane.org>
2016-04-10 8:42 ` sagig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460159290.901.5.camel@haakon3.risingtidesystems.com \
--to=nab@linux-iscsi.org \
--cc=hch@infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.