From mboxrd@z Thu Jan 1 00:00:00 1970 From: vedang.patel@intel.com Subject: [PATCH 1/3] ASoC: hdac_hdmi: Increase loglevel of hex dump printed Date: Tue, 12 Apr 2016 15:08:20 -0700 Message-ID: <1460498902-30454-2-git-send-email-vedang.patel@intel.com> References: <1460498902-30454-1-git-send-email-vedang.patel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by alsa0.perex.cz (Postfix) with ESMTP id 4D5C1265141 for ; Wed, 13 Apr 2016 00:08:47 +0200 (CEST) In-Reply-To: <1460498902-30454-1-git-send-email-vedang.patel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: alsa-devel@alsa-project.org Cc: vinod.koul@intel.com, marc.herbert@intel.com, liam.r.girdwood@intel.com, jeeja.kp@intel.com, subhransu.s.prusty@intel.com, Vedang Patel List-Id: alsa-devel@alsa-project.org From: Vedang Patel The hdac_hdmi codec driver prints the ELD information everytime an external monitor is connected. Make it so that the information is only printed when someone trying to debug the driver explicitly enables it. print_hex_dump uses printk(KERN_DEBUG,... which is different from dev_dbg used elsewhere in the driver: it's always enabled at compile-time. Add #ifdef DEBUG condition for logging consistency. Signed-off-by: Vedang Patel --- sound/soc/codecs/hdac_hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/hdac_hdmi.c b/sound/soc/codecs/hdac_hdmi.c index aaa038f..653fd9e 100644 --- a/sound/soc/codecs/hdac_hdmi.c +++ b/sound/soc/codecs/hdac_hdmi.c @@ -1066,8 +1066,10 @@ static void hdac_hdmi_present_sense(struct hdac_hdmi_pin *pin, int repoll) snd_jack_report(pcm->jack, SND_JACK_AVOUT); } +#ifdef DEBUG print_hex_dump_bytes("ELD: ", DUMP_PREFIX_OFFSET, pin->eld.eld_buffer, pin->eld.eld_size); +#endif } else { pin->eld.monitor_present = false; pin->eld.eld_valid = false; -- 2.1.2