From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqGpD-0007qc-OL for qemu-devel@nongnu.org; Wed, 13 Apr 2016 05:11:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aqGp8-0001wU-6F for qemu-devel@nongnu.org; Wed, 13 Apr 2016 05:11:03 -0400 From: Fam Zheng Date: Wed, 13 Apr 2016 17:10:03 +0800 Message-Id: <1460538604-12132-15-git-send-email-famz@redhat.com> In-Reply-To: <1460538604-12132-1-git-send-email-famz@redhat.com> References: <1460538604-12132-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH for-2.7 14/15] ide-test: Specify "lock-image=off" in command lines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Max Reitz , Jeff Cody , Markus Armbruster , Eric Blake , John Snow , qemu-block@nongnu.org, berrange@redhat.com, pbonzini@redhat.com, den@openvz.org If a failure in a previous test case doesn't clean up the running qemu process (it happens), the subsequent ones can fail because of a image locking failure. That is not an authentic failure of the test case itself and could be sometimes confusing. Disable image locking to avoid that. Signed-off-by: Fam Zheng --- tests/ide-test.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/ide-test.c b/tests/ide-test.c index 0d9ab4d..004ea4f 100644 --- a/tests/ide-test.c +++ b/tests/ide-test.c @@ -504,7 +504,8 @@ static void test_flush(void) uint8_t data; ide_test_start( - "-drive file=blkdebug::%s,if=ide,cache=writeback,format=raw", + "-drive file=blkdebug::%s,if=ide,lock-image=off," + "cache=writeback,format=raw", tmp_path); /* Delay the completion of the flush request until we explicitly do it */ @@ -546,7 +547,7 @@ static void test_retry_flush(const char *machine) ide_test_start( "-vnc none " "-drive file=blkdebug:%s:%s,if=ide,cache=writeback,format=raw," - "rerror=stop,werror=stop", + "rerror=stop,werror=stop,lock-image=off", debug_path, tmp_path); /* FLUSH CACHE command on device 0*/ -- 2.8.0