All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Łukasz Rymanowski" <lukasz.rymanowski@codecoup.pl>
To: linux-bluetooth@vger.kernel.org
Cc: "Łukasz Rymanowski" <lukasz.rymanowski@codecoup.pl>
Subject: [PATCH BlueZ v6 1/5] btgatt-server: Fix GATT device name properties
Date: Wed, 13 Apr 2016 23:09:53 +0200	[thread overview]
Message-ID: <1460581797-3541-2-git-send-email-lukasz.rymanowski@codecoup.pl> (raw)
In-Reply-To: <1460581797-3541-1-git-send-email-lukasz.rymanowski@codecoup.pl>

Since GATT device name characteristic has extended characteristic
property descriptor, that should be set in properties as well.
This patch fixes that.
---
 tools/btgatt-server.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/btgatt-server.c b/tools/btgatt-server.c
index 292b584..099db8a 100644
--- a/tools/btgatt-server.c
+++ b/tools/btgatt-server.c
@@ -419,7 +419,8 @@ static void populate_gap_service(struct server *server)
 	bt_uuid16_create(&uuid, GATT_CHARAC_DEVICE_NAME);
 	gatt_db_service_add_characteristic(service, &uuid,
 					BT_ATT_PERM_READ | BT_ATT_PERM_WRITE,
-					BT_GATT_CHRC_PROP_READ,
+					BT_GATT_CHRC_PROP_READ |
+					BT_GATT_CHRC_PROP_EXT_PROP,
 					gap_device_name_read_cb,
 					gap_device_name_write_cb,
 					server);
-- 
2.5.0


  reply	other threads:[~2016-04-13 21:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13 21:09 [PATCH BlueZ v6 0/5] Couple fixes and improvements Łukasz Rymanowski
2016-04-13 21:09 ` Łukasz Rymanowski [this message]
2016-04-13 21:09 ` [PATCH BlueZ v6 2/5] test-gatt: Fix characteristic properties Łukasz Rymanowski
2016-04-13 21:09 ` [PATCH BlueZ v6 3/5] shared/gatt-db: Extend gatt_db_attribute_get_char_data with ext. prop Łukasz Rymanowski
2016-04-13 21:09 ` [PATCH BlueZ v6 4/5] shared/gatt-server Check for ext. charact. prop. on reliable session Łukasz Rymanowski
2016-04-13 21:09 ` [PATCH BlueZ v6 5/5] gatt-client: Read extended props on service discovery Łukasz Rymanowski
2016-04-22 11:36 ` [PATCH BlueZ v6 0/5] Couple fixes and improvements Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460581797-3541-2-git-send-email-lukasz.rymanowski@codecoup.pl \
    --to=lukasz.rymanowski@codecoup.pl \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.