From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753585AbcDNDMB (ORCPT ); Wed, 13 Apr 2016 23:12:01 -0400 Received: from m50-133.163.com ([123.125.50.133]:55981 "EHLO m50-133.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753490AbcDNDL7 (ORCPT ); Wed, 13 Apr 2016 23:11:59 -0400 From: zengzhaoxiu@163.com To: linux-kernel@vger.kernel.org Cc: Zhaoxiu Zeng , David Woodhouse , Brian Norris , linux-mtd@lists.infradead.org Subject: [PATCH V3 20/29] mtd: use parity functions in inftlcore Date: Thu, 14 Apr 2016 11:11:02 +0800 Message-Id: <1460603462-5453-1-git-send-email-zengzhaoxiu@163.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1460601525-3822-1-git-send-email-zengzhaoxiu@163.com> References: <1460601525-3822-1-git-send-email-zengzhaoxiu@163.com> X-CM-TRANSID: DdGowACXD7BHCg9XOeWhAw--.31873S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7ArW8Ww1Uur4fuF1UXry3CFg_yoW8GF1Dpa 9ruryDCr40kw12va1qkw43Cas5Ka97tay8GFWDWwnaqr15tF129rn5Kr1rXFyjqFW2qF1Y qrs5CFyF9ayDZ3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07bOa9-UUUUU= X-Originating-IP: [112.95.225.98] X-CM-SenderInfo: p2hqw6xkdr5xrx6rljoofrz/1tbiowtLgFUL5oC4qwAAsI Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhaoxiu Zeng Signed-off-by: Zhaoxiu Zeng --- drivers/mtd/inftlcore.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/mtd/inftlcore.c b/drivers/mtd/inftlcore.c index b66b541..8c9457b 100644 --- a/drivers/mtd/inftlcore.c +++ b/drivers/mtd/inftlcore.c @@ -457,15 +457,6 @@ static u16 INFTL_makefreeblock(struct INFTLrecord *inftl, unsigned pendingblock) return INFTL_foldchain(inftl, LongestChain, pendingblock); } -static int nrbits(unsigned int val, int bitcount) -{ - int i, total = 0; - - for (i = 0; (i < bitcount); i++) - total += (((0x1 << i) & val) ? 1 : 0); - return total; -} - /* * INFTL_findwriteunit: Return the unit number into which we can write * for this block. Make it available if it isn't already. @@ -593,10 +584,10 @@ hitused: if (prev_block < inftl->nb_blocks) prev_block -= inftl->firstEUN; - parity = (nrbits(thisVUC, 16) & 0x1) ? 0x1 : 0; - parity |= (nrbits(prev_block, 16) & 0x1) ? 0x2 : 0; - parity |= (nrbits(anac, 8) & 0x1) ? 0x4 : 0; - parity |= (nrbits(nacs, 8) & 0x1) ? 0x8 : 0; + parity = parity16(thisVUC); + parity |= parity16(prev_block) << 1; + parity |= parity8(anac) << 2; + parity |= parity8(nacs) << 3; oob.u.a.virtualUnitNo = cpu_to_le16(thisVUC); oob.u.a.prevUnitNo = cpu_to_le16(prev_block); -- 2.5.0