From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:35965 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751617AbcDQMmi (ORCPT ); Sun, 17 Apr 2016 08:42:38 -0400 Message-ID: <1460896953.15362.2.camel@sipsolutions.net> (sfid-20160417_144308_878297_106CBB57) Subject: Re: [PATCH v3] prism54: isl_38xx: Replace 'struct timeval' From: Johannes Berg To: Arnd Bergmann Cc: Tina Ruchandani , y2038@lists.linaro.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Date: Sun, 17 Apr 2016 14:42:33 +0200 In-Reply-To: <5521267.mr5HLCdTY6@wuerfel> References: <20160413060916.GA21184@localhost> <1460536706.3057.3.camel@sipsolutions.net> <5521267.mr5HLCdTY6@wuerfel> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sun, 2016-04-17 at 01:34 +0200, Arnd Bergmann wrote: > On Wednesday 13 April 2016 10:38:26 Johannes Berg wrote: > > > > > > > > The patch was build-tested / debugged by removing the > > > "if VERBOSE > SHOW_ERROR_MESSAGES" guards. > > Stands to reason that we should just remove the (more or less) dead > > code, since I don't think anyone really ever touches this driver > > any > > more or will ever again ... > Do you mean removing all DEBUG() statements from the driver, or > removing the entire driver? > We tried removing the driver once, since p54 supposedly drives the same hardware, but some people had certain use cases that didn't work there, apparently. I was thinking more restrictively of just the stuff that can't even be built without modifying the sources - like the "#if VERBOSE" thing. johannes From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Berg Subject: Re: [PATCH v3] prism54: isl_38xx: Replace 'struct timeval' Date: Sun, 17 Apr 2016 14:42:33 +0200 Message-ID: <1460896953.15362.2.camel@sipsolutions.net> References: <20160413060916.GA21184@localhost> <1460536706.3057.3.camel@sipsolutions.net> <5521267.mr5HLCdTY6@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: y2038@lists.linaro.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, Tina Ruchandani , linux-kernel@vger.kernel.org To: Arnd Bergmann Return-path: In-Reply-To: <5521267.mr5HLCdTY6@wuerfel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: y2038-bounces@lists.linaro.org Sender: "Y2038" List-Id: netdev.vger.kernel.org T24gU3VuLCAyMDE2LTA0LTE3IGF0IDAxOjM0ICswMjAwLCBBcm5kIEJlcmdtYW5uIHdyb3RlOgo+ IE9uIFdlZG5lc2RheSAxMyBBcHJpbCAyMDE2IDEwOjM4OjI2IEpvaGFubmVzIEJlcmcgd3JvdGU6 Cj4gPiAKPiA+ID4gCj4gPiA+IFRoZSBwYXRjaCB3YXMgYnVpbGQtdGVzdGVkIC8gZGVidWdnZWQg YnkgcmVtb3ZpbmcgdGhlCj4gPiA+ICJpZiBWRVJCT1NFID4gU0hPV19FUlJPUl9NRVNTQUdFUyIg Z3VhcmRzLgo+ID4gU3RhbmRzIHRvIHJlYXNvbiB0aGF0IHdlIHNob3VsZCBqdXN0IHJlbW92ZSB0 aGUgKG1vcmUgb3IgbGVzcykgZGVhZAo+ID4gY29kZSwgc2luY2UgSSBkb24ndCB0aGluayBhbnlv bmUgcmVhbGx5IGV2ZXIgdG91Y2hlcyB0aGlzIGRyaXZlcgo+ID4gYW55Cj4gPiBtb3JlIG9yIHdp bGwgZXZlciBhZ2FpbiAuLi4KPiBEbyB5b3UgbWVhbiByZW1vdmluZyBhbGwgREVCVUcoKSBzdGF0 ZW1lbnRzIGZyb20gdGhlIGRyaXZlciwgb3IKPiByZW1vdmluZyB0aGUgZW50aXJlIGRyaXZlcj8K PiAKCldlIHRyaWVkIHJlbW92aW5nIHRoZSBkcml2ZXIgb25jZSwgc2luY2UgcDU0IHN1cHBvc2Vk bHkgZHJpdmVzIHRoZSBzYW1lCmhhcmR3YXJlLCBidXQgc29tZSBwZW9wbGUgaGFkIGNlcnRhaW4g dXNlIGNhc2VzIHRoYXQgZGlkbid0IHdvcmsgdGhlcmUsCmFwcGFyZW50bHkuCgpJIHdhcyB0aGlu a2luZyBtb3JlIHJlc3RyaWN0aXZlbHkgb2YganVzdCB0aGUgc3R1ZmYgdGhhdCBjYW4ndCBldmVu IGJlCmJ1aWx0IHdpdGhvdXQgbW9kaWZ5aW5nIHRoZSBzb3VyY2VzIC0gbGlrZSB0aGUgIiNpZiBW RVJCT1NFIiB0aGluZy4KCmpvaGFubmVzCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fClkyMDM4IG1haWxpbmcgbGlzdApZMjAzOEBsaXN0cy5saW5hcm8ub3Jn Cmh0dHBzOi8vbGlzdHMubGluYXJvLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3kyMDM4Cg==