From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Akash Goel <akash.goel@intel.com>
Subject: Re: [PATCH] drm/i915/shrinker: Only report objects with extra pinned pages as pinned
Date: Wed, 20 Apr 2016 11:56:02 +0300 [thread overview]
Message-ID: <1461142562.8815.1.camel@linux.intel.com> (raw)
In-Reply-To: <1461138235-28485-1-git-send-email-chris@chris-wilson.co.uk>
On ke, 2016-04-20 at 08:43 +0100, Chris Wilson wrote:
> When iterating over the bound list, we expect all objects there to have
> their pages pinned (by the bound VMA). So only add those objects with
> additional pin count on their pages as "pinned". These should be those
> objects used for display and hardware access.
>
> Reported-by: Akash Goel <akash.goel@intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Akash Goel <akash.goel@intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem_shrinker.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_shrinker.c b/drivers/gpu/drm/i915/i915_gem_shrinker.c
> index d46388f25e04..4e4fcfa76b4c 100644
> --- a/drivers/gpu/drm/i915/i915_gem_shrinker.c
> +++ b/drivers/gpu/drm/i915/i915_gem_shrinker.c
> @@ -361,7 +361,7 @@ i915_gem_shrinker_oom(struct notifier_block *nb, unsigned long event, void *ptr)
> if (!obj->base.filp)
> continue;
>
> - if (obj->pages_pin_count)
> + if (obj->pages_pin_count > num_vma_bound(obj))
> pinned += obj->base.size;
> else
> bound += obj->base.size;
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-20 8:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 7:43 [PATCH] drm/i915/shrinker: Only report objects with extra pinned pages as pinned Chris Wilson
2016-04-20 8:24 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-04-20 8:56 ` Joonas Lahtinen [this message]
2016-04-20 11:04 ` [PATCH v2 1/3] " Chris Wilson
2016-04-20 11:04 ` [PATCH v2 2/3] drm/i915/shrinker: Report "unevictable" pages Chris Wilson
2016-04-20 12:02 ` Joonas Lahtinen
2016-04-20 11:04 ` [PATCH v2 3/3] drm/i915/shrinker: Only shmemfs objects are backed by swap Chris Wilson
2016-04-20 12:07 ` Joonas Lahtinen
2016-04-20 9:03 ` ✓ Fi.CI.BAT: success for drm/i915/shrinker: Only report objects with extra pinned pages as pinned Patchwork
2016-04-20 10:23 ` Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461142562.8815.1.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=akash.goel@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.