From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752321AbcDWA2a (ORCPT ); Fri, 22 Apr 2016 20:28:30 -0400 Received: from mga14.intel.com ([192.55.52.115]:47591 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751927AbcDWA15 (ORCPT ); Fri, 22 Apr 2016 20:27:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,519,1455004800"; d="scan'208";a="964660960" From: Vikas Shivappa To: tony.luck@intel.com, ravi.v.shankar@intel.com, fenghua.yu@intel.com, vikas.shivappa@intel.com, vikas.shivappa@linux.intel.com Cc: x86@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, peterz@infradead.org, h.peter.anvin@intel.com Subject: [PATCH 4/4] perf/x86/cqm: Support cqm/mbm only for perf events Date: Fri, 22 Apr 2016 17:27:21 -0700 Message-Id: <1461371241-4258-5-git-send-email-vikas.shivappa@linux.intel.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1461371241-4258-1-git-send-email-vikas.shivappa@linux.intel.com> References: <1461371241-4258-1-git-send-email-vikas.shivappa@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The cgroup support for cqm is broken. Instead of mapping RMID to a cgroup currently its mapped to the task and then hence when task moves cgroup we get incorrect count. Also the conflict handling code which is meant to handle the case of co-existing cgroup and task events, is broken. It reports very confusing numbers of intermittent zero and some occupancy when perf is run with cgroup and task events. Hence removing support for the parts which are broken rather than pretending to support it and giving incorrect data. Signed-off-by: Vikas Shivappa --- arch/x86/events/intel/cqm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/events/intel/cqm.c b/arch/x86/events/intel/cqm.c index 7328b73..4633fb3 100644 --- a/arch/x86/events/intel/cqm.c +++ b/arch/x86/events/intel/cqm.c @@ -1479,7 +1479,8 @@ static int intel_cqm_event_init(struct perf_event *event) event->attr.exclude_idle || event->attr.exclude_host || event->attr.exclude_guest || - event->attr.sample_period) /* no sampling */ + event->attr.sample_period || /* no sampling */ + !(event->attach_state & PERF_ATTACH_TASK)) return -EINVAL; INIT_LIST_HEAD(&event->hw.cqm_group_entry); -- 1.9.1