From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH] drm/i915: tidy up gen8_init_scratch Date: Wed, 27 Apr 2016 10:39:16 +0300 Message-ID: <1461742756.3986.6.camel@linux.intel.com> References: <1461662839-14690-1-git-send-email-matthew.auld@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 609E76E246 for ; Wed, 27 Apr 2016 07:38:04 +0000 (UTC) In-Reply-To: <1461662839-14690-1-git-send-email-matthew.auld@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matthew Auld , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gdGksIDIwMTYtMDQtMjYgYXQgMTA6MjcgKzAxMDAsIE1hdHRoZXcgQXVsZCB3cm90ZToKPiBV c2UgZ290byB0ZWFyZG93biBwYXRoIGFuZCBhbHNvIGVuc3VyZSB3ZSByZXNldCBhbnkgc3RydWN0 IG1lbWJlcnMgd2hpY2gKPiB3b3VsZCBvdGhlcndpc2UgY29udGFpbiBhbiBlcnJvciBlbmNvZGVk IHBvaW50ZXIsIGFuZCBjb3VsZCBiZSBtaXN0YWtlbgo+IGZvciBhIHZhbGlkIGFkZHJlc3MuCj4g Cj4gQ2M6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4K PiBTaWduZWQtb2ZmLWJ5OiBNYXR0aGV3IEF1bGQgPG1hdHRoZXcuYXVsZEBpbnRlbC5jb20+CgpB cyB0aGlzIGdvZXMgdGhyb3VnaCB0aGUgd2hvbGUgZnVuY3Rpb24sIGdvb2QgaWRlYSB0byBjaGVj ayB3aXRoIGdpdApibGFtZSBmb3IgdGhlIGZ1bmN0aW9uIGF1dGhvciBhbmQgQ0MgKGluIHRoaXMg Y2FzZSBNaWthLCBhZGRlZCBhcyBDQykuCgo+IC0tLQo+IMKgZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW1fZ3R0LmMgfCAzNiArKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0K PiDCoDEgZmlsZSBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkKPiAK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYwo+IGluZGV4IDBkNjY2YjMuLmE3MjNiNzQg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYwo+IEBAIC04NjYsMzEgKzg2Niwz MSBAQCBzdGF0aWMgdm9pZCBnZW44X2ZyZWVfcGFnZV90YWJsZXMoc3RydWN0IGRybV9kZXZpY2Ug KmRldiwKPiDCoHN0YXRpYyBpbnQgZ2VuOF9pbml0X3NjcmF0Y2goc3RydWN0IGk5MTVfYWRkcmVz c19zcGFjZSAqdm0pCj4gwqB7Cj4gwqAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IHZtLT5kZXY7 Cj4gKwlpbnQgcmV0Owo+IMKgCj4gwqAJdm0tPnNjcmF0Y2hfcGFnZSA9IGFsbG9jX3NjcmF0Y2hf cGFnZShkZXYpOwo+IC0JaWYgKElTX0VSUih2bS0+c2NyYXRjaF9wYWdlKSkKPiAtCQlyZXR1cm4g UFRSX0VSUih2bS0+c2NyYXRjaF9wYWdlKTsKPiArCWlmIChJU19FUlIodm0tPnNjcmF0Y2hfcGFn ZSkpIHsKPiArCQlyZXQgPSBQVFJfRVJSKHZtLT5zY3JhdGNoX3BhZ2UpOwo+ICsJCWdvdG8gZmFp bF9zY3JhdGNoOwo+ICsJfQo+IMKgCj4gwqAJdm0tPnNjcmF0Y2hfcHQgPSBhbGxvY19wdChkZXYp Owo+IMKgCWlmIChJU19FUlIodm0tPnNjcmF0Y2hfcHQpKSB7Cj4gLQkJZnJlZV9zY3JhdGNoX3Bh Z2UoZGV2LCB2bS0+c2NyYXRjaF9wYWdlKTsKPiAtCQlyZXR1cm4gUFRSX0VSUih2bS0+c2NyYXRj aF9wdCk7Cj4gKwkJcmV0ID0gUFRSX0VSUih2bS0+c2NyYXRjaF9wdCk7Cj4gKwkJZ290byBmYWls X3B0Owo+IMKgCX0KPiDCoAo+IMKgCXZtLT5zY3JhdGNoX3BkID0gYWxsb2NfcGQoZGV2KTsKPiDC oAlpZiAoSVNfRVJSKHZtLT5zY3JhdGNoX3BkKSkgewo+IC0JCWZyZWVfcHQoZGV2LCB2bS0+c2Ny YXRjaF9wdCk7Cj4gLQkJZnJlZV9zY3JhdGNoX3BhZ2UoZGV2LCB2bS0+c2NyYXRjaF9wYWdlKTsK PiAtCQlyZXR1cm4gUFRSX0VSUih2bS0+c2NyYXRjaF9wZCk7Cj4gKwkJcmV0ID0gUFRSX0VSUih2 bS0+c2NyYXRjaF9wZCk7Cj4gKwkJZ290byBmYWlsX3BkOwo+IMKgCX0KPiDCoAo+IMKgCWlmIChV U0VTX0ZVTExfNDhCSVRfUFBHVFQoZGV2KSkgewo+IMKgCQl2bS0+c2NyYXRjaF9wZHAgPSBhbGxv Y19wZHAoZGV2KTsKPiDCoAkJaWYgKElTX0VSUih2bS0+c2NyYXRjaF9wZHApKSB7Cj4gLQkJCWZy ZWVfcGQoZGV2LCB2bS0+c2NyYXRjaF9wZCk7Cj4gLQkJCWZyZWVfcHQoZGV2LCB2bS0+c2NyYXRj aF9wdCk7Cj4gLQkJCWZyZWVfc2NyYXRjaF9wYWdlKGRldiwgdm0tPnNjcmF0Y2hfcGFnZSk7Cj4g LQkJCXJldHVybiBQVFJfRVJSKHZtLT5zY3JhdGNoX3BkcCk7Cj4gKwkJCXJldCA9IFBUUl9FUlIo dm0tPnNjcmF0Y2hfcGRwKTsKPiArCQkJZ290byBmYWlsX3BkcDsKPiDCoAkJfQo+IMKgCX0KPiDC oAo+IEBAIC05MDAsNiArOTAwLDIwIEBAIHN0YXRpYyBpbnQgZ2VuOF9pbml0X3NjcmF0Y2goc3Ry dWN0IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0pCj4gwqAJCWdlbjhfaW5pdGlhbGl6ZV9wZHAodm0s IHZtLT5zY3JhdGNoX3BkcCk7Cj4gwqAKPiDCoAlyZXR1cm4gMDsKPiArCj4gK2ZhaWxfcGRwOgo+ ICsJdm0tPnNjcmF0Y2hfcGRwID0gTlVMTDsKCkkgZG9uJ3QgdGhpbmsgYXNzaWduaW5nIHRvIE5V TEwgaXMgbmVjZXNzYXJ5LiBJZiB0aGlzIGZ1bmN0aW9uIGZhaWxzLAppdCdsbCBsZWFkIHRvIGRy aXZlciBpbml0IGZhaWx1cmUuCgo+ICsJZnJlZV9wZChkZXYsIHZtLT5zY3JhdGNoX3BkKTsKPiAr ZmFpbF9wZDoKPiArCXZtLT5zY3JhdGNoX3BkID0gTlVMTDsKPiArCWZyZWVfcHQoZGV2LCB2bS0+ c2NyYXRjaF9wdCk7Cj4gK2ZhaWxfcHQ6Cj4gKwl2bS0+c2NyYXRjaF9wdCA9IE5VTEw7Cj4gKwlm cmVlX3NjcmF0Y2hfcGFnZShkZXYsIHZtLT5zY3JhdGNoX3BhZ2UpOwo+ICtmYWlsX3NjcmF0Y2g6 Cj4gKwl2bS0+c2NyYXRjaF9wYWdlID0gTlVMTDsKPiArCgpTYW1lIGNvbW1lbnQgYXMgaW4gdGhl IGxhc3QgcGF0Y2gsIHJlbGF0ZWQgdG8gbGFiZWxzLCB0aGUgbGFiZWwgc2hvdWxkCmRlc2NyaWJl IHRoZSBjb2RlIHVuZGVyIGdvdG8gc2VjdGlvbiwgbm90IHRoZSBjb2RlL3NpdHVhdGlvbiB0aGF0 IGp1bXBzCnRvIGl0LgoKUmVnYXJkcywgSm9vbmFzCgo+ICsJcmV0dXJuIHJldDsKPiDCoH0KPiDC oAo+IMKgc3RhdGljIGludCBnZW44X3BwZ3R0X25vdGlmeV92Z3Qoc3RydWN0IGk5MTVfaHdfcHBn dHQgKnBwZ3R0LCBib29sIGNyZWF0ZSkKLS0gCkpvb25hcyBMYWh0aW5lbgpPcGVuIFNvdXJjZSBU ZWNobm9sb2d5IENlbnRlcgpJbnRlbCBDb3Jwb3JhdGlvbgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK