From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-media-owner@vger.kernel.org>
Received: from lb3-smtp-cloud3.xs4all.net ([194.109.24.30]:57446 "EHLO
	lb3-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1752454AbcD2JjS (ORCPT
	<rfc822;linux-media@vger.kernel.org>);
	Fri, 29 Apr 2016 05:39:18 -0400
From: Hans Verkuil <hverkuil@xs4all.nl>
To: linux-media@vger.kernel.org
Cc: tomi.valkeinen@ti.com, dri-devel@lists.freedesktop.org,
	Hans Verkuil <hans.verkuil@cisco.com>
Subject: [RFC PATCH 3/3] encoder-tpd12s015: keep the ls_oe_gpio on while the phys_addr is valid
Date: Fri, 29 Apr 2016 11:39:06 +0200
Message-Id: <1461922746-17521-4-git-send-email-hverkuil@xs4all.nl>
In-Reply-To: <1461922746-17521-1-git-send-email-hverkuil@xs4all.nl>
References: <1461922746-17521-1-git-send-email-hverkuil@xs4all.nl>
Sender: linux-media-owner@vger.kernel.org
List-ID: <linux-media.vger.kernel.org>

From: Hans Verkuil <hans.verkuil@cisco.com>

As long as there is a valid physical address in the EDID and the omap
CEC support is enabled, then we keep ls_oe_gpio on to ensure the CEC
signal is passed through the tpd12s015.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Suggested-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c b/drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c
index 916a899..efbba23 100644
--- a/drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c
+++ b/drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c
@@ -16,6 +16,7 @@
 #include <linux/platform_device.h>
 #include <linux/gpio/consumer.h>
 
+#include <media/cec-edid.h>
 #include <video/omapdss.h>
 #include <video/omap-panel-data.h>
 
@@ -65,6 +66,7 @@ static void tpd_disconnect(struct omap_dss_device *dssdev,
 		return;
 
 	gpiod_set_value_cansleep(ddata->ct_cp_hpd_gpio, 0);
+	gpiod_set_value_cansleep(ddata->ls_oe_gpio, 0);
 
 	dst->src = NULL;
 	dssdev->dst = NULL;
@@ -142,6 +144,7 @@ static int tpd_read_edid(struct omap_dss_device *dssdev,
 {
 	struct panel_drv_data *ddata = to_panel_data(dssdev);
 	struct omap_dss_device *in = ddata->in;
+	bool valid_phys_addr = 0;
 	int r;
 
 	if (!gpiod_get_value_cansleep(ddata->hpd_gpio))
@@ -151,7 +154,15 @@ static int tpd_read_edid(struct omap_dss_device *dssdev,
 
 	r = in->ops.hdmi->read_edid(in, edid, len);
 
-	gpiod_set_value_cansleep(ddata->ls_oe_gpio, 0);
+#ifdef CONFIG_OMAP2_DSS_HDMI_CEC
+	/*
+	 * In order to support CEC this pin should remain high
+	 * as long as the EDID has a valid physical address.
+	 */
+	valid_phys_addr =
+		cec_get_edid_phys_addr(edid, r, NULL) != CEC_PHYS_ADDR_INVALID;
+#endif
+	gpiod_set_value_cansleep(ddata->ls_oe_gpio, valid_phys_addr);
 
 	return r;
 }
-- 
2.8.1


From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hans Verkuil <hverkuil@xs4all.nl>
Subject: [RFC PATCH 3/3] encoder-tpd12s015: keep the ls_oe_gpio on while the
 phys_addr is valid
Date: Fri, 29 Apr 2016 11:39:06 +0200
Message-ID: <1461922746-17521-4-git-send-email-hverkuil@xs4all.nl>
References: <1461922746-17521-1-git-send-email-hverkuil@xs4all.nl>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from lb3-smtp-cloud3.xs4all.net (lb3-smtp-cloud3.xs4all.net
 [194.109.24.30])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 1C25D6EE96
 for <dri-devel@lists.freedesktop.org>; Fri, 29 Apr 2016 09:39:20 +0000 (UTC)
In-Reply-To: <1461922746-17521-1-git-send-email-hverkuil@xs4all.nl>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: linux-media@vger.kernel.org
Cc: tomi.valkeinen@ti.com, Hans Verkuil <hans.verkuil@cisco.com>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

RnJvbTogSGFucyBWZXJrdWlsIDxoYW5zLnZlcmt1aWxAY2lzY28uY29tPgoKQXMgbG9uZyBhcyB0
aGVyZSBpcyBhIHZhbGlkIHBoeXNpY2FsIGFkZHJlc3MgaW4gdGhlIEVESUQgYW5kIHRoZSBvbWFw
CkNFQyBzdXBwb3J0IGlzIGVuYWJsZWQsIHRoZW4gd2Uga2VlcCBsc19vZV9ncGlvIG9uIHRvIGVu
c3VyZSB0aGUgQ0VDCnNpZ25hbCBpcyBwYXNzZWQgdGhyb3VnaCB0aGUgdHBkMTJzMDE1LgoKU2ln
bmVkLW9mZi1ieTogSGFucyBWZXJrdWlsIDxoYW5zLnZlcmt1aWxAY2lzY28uY29tPgpTdWdnZXN0
ZWQtYnk6IFRvbWkgVmFsa2VpbmVuIDx0b21pLnZhbGtlaW5lbkB0aS5jb20+Ci0tLQogZHJpdmVy
cy9ncHUvZHJtL29tYXBkcm0vZGlzcGxheXMvZW5jb2Rlci10cGQxMnMwMTUuYyB8IDEzICsrKysr
KysrKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0p
CgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vZGlzcGxheXMvZW5jb2Rlci10
cGQxMnMwMTUuYyBiL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL2Rpc3BsYXlzL2VuY29kZXItdHBk
MTJzMDE1LmMKaW5kZXggOTE2YTg5OS4uZWZiYmEyMyAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUv
ZHJtL29tYXBkcm0vZGlzcGxheXMvZW5jb2Rlci10cGQxMnMwMTUuYworKysgYi9kcml2ZXJzL2dw
dS9kcm0vb21hcGRybS9kaXNwbGF5cy9lbmNvZGVyLXRwZDEyczAxNS5jCkBAIC0xNiw2ICsxNiw3
IEBACiAjaW5jbHVkZSA8bGludXgvcGxhdGZvcm1fZGV2aWNlLmg+CiAjaW5jbHVkZSA8bGludXgv
Z3Bpby9jb25zdW1lci5oPgogCisjaW5jbHVkZSA8bWVkaWEvY2VjLWVkaWQuaD4KICNpbmNsdWRl
IDx2aWRlby9vbWFwZHNzLmg+CiAjaW5jbHVkZSA8dmlkZW8vb21hcC1wYW5lbC1kYXRhLmg+CiAK
QEAgLTY1LDYgKzY2LDcgQEAgc3RhdGljIHZvaWQgdHBkX2Rpc2Nvbm5lY3Qoc3RydWN0IG9tYXBf
ZHNzX2RldmljZSAqZHNzZGV2LAogCQlyZXR1cm47CiAKIAlncGlvZF9zZXRfdmFsdWVfY2Fuc2xl
ZXAoZGRhdGEtPmN0X2NwX2hwZF9ncGlvLCAwKTsKKwlncGlvZF9zZXRfdmFsdWVfY2Fuc2xlZXAo
ZGRhdGEtPmxzX29lX2dwaW8sIDApOwogCiAJZHN0LT5zcmMgPSBOVUxMOwogCWRzc2Rldi0+ZHN0
ID0gTlVMTDsKQEAgLTE0Miw2ICsxNDQsNyBAQCBzdGF0aWMgaW50IHRwZF9yZWFkX2VkaWQoc3Ry
dWN0IG9tYXBfZHNzX2RldmljZSAqZHNzZGV2LAogewogCXN0cnVjdCBwYW5lbF9kcnZfZGF0YSAq
ZGRhdGEgPSB0b19wYW5lbF9kYXRhKGRzc2Rldik7CiAJc3RydWN0IG9tYXBfZHNzX2RldmljZSAq
aW4gPSBkZGF0YS0+aW47CisJYm9vbCB2YWxpZF9waHlzX2FkZHIgPSAwOwogCWludCByOwogCiAJ
aWYgKCFncGlvZF9nZXRfdmFsdWVfY2Fuc2xlZXAoZGRhdGEtPmhwZF9ncGlvKSkKQEAgLTE1MSw3
ICsxNTQsMTUgQEAgc3RhdGljIGludCB0cGRfcmVhZF9lZGlkKHN0cnVjdCBvbWFwX2Rzc19kZXZp
Y2UgKmRzc2RldiwKIAogCXIgPSBpbi0+b3BzLmhkbWktPnJlYWRfZWRpZChpbiwgZWRpZCwgbGVu
KTsKIAotCWdwaW9kX3NldF92YWx1ZV9jYW5zbGVlcChkZGF0YS0+bHNfb2VfZ3BpbywgMCk7Cisj
aWZkZWYgQ09ORklHX09NQVAyX0RTU19IRE1JX0NFQworCS8qCisJICogSW4gb3JkZXIgdG8gc3Vw
cG9ydCBDRUMgdGhpcyBwaW4gc2hvdWxkIHJlbWFpbiBoaWdoCisJICogYXMgbG9uZyBhcyB0aGUg
RURJRCBoYXMgYSB2YWxpZCBwaHlzaWNhbCBhZGRyZXNzLgorCSAqLworCXZhbGlkX3BoeXNfYWRk
ciA9CisJCWNlY19nZXRfZWRpZF9waHlzX2FkZHIoZWRpZCwgciwgTlVMTCkgIT0gQ0VDX1BIWVNf
QUREUl9JTlZBTElEOworI2VuZGlmCisJZ3Bpb2Rfc2V0X3ZhbHVlX2NhbnNsZWVwKGRkYXRhLT5s
c19vZV9ncGlvLCB2YWxpZF9waHlzX2FkZHIpOwogCiAJcmV0dXJuIHI7CiB9Ci0tIAoyLjguMQoK
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==