All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Goldstein <cardoe@cardoe.com>
To: xen-devel@lists.xen.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Doug Goldstein <cardoe@cardoe.com>, Tim Deegan <tim@xen.org>,
	Jan Beulich <jbeulich@suse.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [PATCH v2 5/7] build: wire up pre-existing debug build flag
Date: Tue,  3 May 2016 09:29:11 -0500	[thread overview]
Message-ID: <1462285753-5588-6-git-send-email-cardoe@cardoe.com> (raw)
In-Reply-To: <1462285753-5588-1-git-send-email-cardoe@cardoe.com>

This allows 'make debug=n' and 'make debug=y' work as it did previously
but only in the case of the user not having an existing .config file
from a 'make menuconfig'. This is because the command line 'debug' flag
can only be used to set the default value and if the user has already
built up a config with their real preference set.

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
---
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: George Dunlap <George.Dunlap@eu.citrix.com>
CC: Ian Jackson <ian.jackson@eu.citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Tim Deegan <tim@xen.org>
CC: Wei Liu <wei.liu2@citrix.com>
---
 xen/Kconfig.debug | 5 +++++
 xen/Makefile      | 1 +
 2 files changed, 6 insertions(+)

diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug
index c75cf1d..9aefa16 100644
--- a/xen/Kconfig.debug
+++ b/xen/Kconfig.debug
@@ -1,6 +1,11 @@
+config DEBUG_ENV
+	bool
+	option env="debug"
 
 menuconfig DEBUG
 	bool "Debugging Options"
+	default y if DEBUG_ENV = "y"
+	default n
 	---help---
 	  If you want to debug Xen say Y and select any additional debugging
 	  support options. Enabling this option is intended for development
diff --git a/xen/Makefile b/xen/Makefile
index 0d5f240..31cca71 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -27,6 +27,7 @@ SRCARCH=$(shell echo $(ARCH) | sed -e 's/x86.*/x86/' -e s'/arm\(32\|64\)/arm/g')
 # Don't break if the build process wasn't called from the top level
 # we need XEN_TARGET_ARCH to generate the proper config
 include $(XEN_ROOT)/Config.mk
+export debug
 
 # Allow someone to change their config file
 export KCONFIG_CONFIG ?= .config
-- 
2.7.3


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-05-03 14:29 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-03 14:29 [PATCH v2 0/7] Kconfig debug options Doug Goldstein
2016-05-03 14:29 ` [PATCH v2 1/7] build: add debug menu to Kconfig Doug Goldstein
2016-05-03 14:38   ` Jan Beulich
2016-05-03 14:39     ` Doug Goldstein
2016-05-03 15:05   ` Jan Beulich
2016-05-03 15:10     ` Andrew Cooper
2016-05-03 15:18       ` Jan Beulich
2016-05-04  2:22         ` Doug Goldstein
2016-05-04  7:17           ` Jan Beulich
2016-05-03 14:29 ` [PATCH v2 2/7] build: convert crash_debug " Doug Goldstein
2016-05-03 14:43   ` Jan Beulich
2016-05-03 14:48     ` Doug Goldstein
2016-05-03 15:19       ` Jan Beulich
2016-05-04  3:10     ` Doug Goldstein
2016-05-04  7:20       ` Jan Beulich
2016-05-03 14:47   ` Andrew Cooper
2016-05-03 15:02     ` Jan Beulich
2016-05-03 14:29 ` [PATCH v2 3/7] build: convert verbose " Doug Goldstein
2016-05-03 14:47   ` Jan Beulich
2016-05-03 14:29 ` [PATCH v2 4/7] build: convert frame_pointer " Doug Goldstein
2016-05-03 14:49   ` Jan Beulich
2016-05-03 14:29 ` Doug Goldstein [this message]
2016-05-03 14:50   ` [PATCH v2 5/7] build: wire up pre-existing debug build flag Jan Beulich
2016-05-04  3:13     ` Doug Goldstein
2016-05-03 14:29 ` [PATCH v2 6/7] build: convert perfc{, _arrays} to Kconfig Doug Goldstein
2016-05-03 14:57   ` Jan Beulich
2016-05-03 14:29 ` [PATCH v2 7/7] build: convert lock_profile " Doug Goldstein
2016-05-03 14:59   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462285753-5588-6-git-send-email-cardoe@cardoe.com \
    --to=cardoe@cardoe.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.