From: Reza Arbab <arbab@linux.vnet.ibm.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2] memory-hotplug: fix store_mem_state() return value
Date: Thu, 5 May 2016 14:07:24 -0500 [thread overview]
Message-ID: <1462475244-11859-1-git-send-email-arbab@linux.vnet.ibm.com> (raw)
Attempting to online memory which is already online will cause this:
1. store_mem_state() called with buf="online"
2. device_online() returns 1 because device is already online
3. store_mem_state() returns 1
4. calling code interprets this as 1-byte buffer read
5. store_mem_state() called again with buf="nline"
6. store_mem_state() returns -EINVAL
Example:
$ cat /sys/devices/system/memory/memory0/state
online
$ echo online > /sys/devices/system/memory/memory0/state
-bash: echo: write error: Invalid argument
Fix the return value of store_mem_state() so this doesn't happen.
Signed-off-by: Reza Arbab <arbab@linux.vnet.ibm.com>
---
drivers/base/memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index 961e2cf..eebd9a8 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -359,7 +359,7 @@ store_mem_state(struct device *dev,
err:
unlock_device_hotplug();
- if (ret)
+ if (ret < 0)
return ret;
return count;
}
--
1.8.3.1
next reply other threads:[~2016-05-05 19:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 19:07 Reza Arbab [this message]
2016-05-26 14:43 ` [PATCH v2] memory-hotplug: fix store_mem_state() return value Reza Arbab
2016-05-26 15:34 ` Greg Kroah-Hartman
2016-05-26 15:35 ` Greg Kroah-Hartman
2016-08-31 12:21 ` Greg Kroah-Hartman
2016-08-31 14:37 ` Reza Arbab
2016-08-31 15:01 ` Greg Kroah-Hartman
2016-08-31 15:44 ` [RESEND PATCH " Reza Arbab
2016-08-31 15:44 ` Reza Arbab
2016-08-31 20:25 ` Andrew Morton
2016-08-31 20:25 ` Andrew Morton
2016-08-31 21:06 ` David Rientjes
2016-08-31 21:06 ` David Rientjes
2016-08-31 23:38 ` Reza Arbab
2016-08-31 23:38 ` Reza Arbab
2016-09-01 0:03 ` David Rientjes
2016-09-01 0:03 ` David Rientjes
2016-09-01 0:17 ` Reza Arbab
2016-09-01 0:17 ` Reza Arbab
2016-09-01 0:28 ` David Rientjes
2016-09-01 0:28 ` David Rientjes
2016-09-01 1:57 ` Reza Arbab
2016-09-01 1:57 ` Reza Arbab
2016-08-31 14:38 ` Reza Arbab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462475244-11859-1-git-send-email-arbab@linux.vnet.ibm.com \
--to=arbab@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.