From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pa0-x233.google.com ([2607:f8b0:400e:c03::233]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ayOsK-0005aR-JB for ath10k@lists.infradead.org; Thu, 05 May 2016 19:23:53 +0000 Received: by mail-pa0-x233.google.com with SMTP id bt5so38666983pac.3 for ; Thu, 05 May 2016 12:23:29 -0700 (PDT) Message-ID: <1462476207.13075.20.camel@edumazet-glaptop3.roam.corp.google.com> Subject: Re: [Codel] fq_codel_drop vs a udp flood From: Eric Dumazet Date: Thu, 05 May 2016 12:23:27 -0700 In-Reply-To: References: <1462125592.5535.194.camel@edumazet-glaptop3.roam.corp.google.com> <865DA393-262D-40B6-A9D3-1B978CD5F6C6@gmail.com> <1462128385.5535.200.camel@edumazet-glaptop3.roam.corp.google.com> <1462136140.5535.219.camel@edumazet-glaptop3.roam.corp.google.com> <1462201620.5535.250.camel@edumazet-glaptop3.roam.corp.google.com> <1462205669.5535.254.camel@edumazet-glaptop3.roam.corp.google.com> <1462464776.13075.18.camel@edumazet-glaptop3.roam.corp.google.com> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Roman Yeryomin Cc: Jonathan Morton , "codel@lists.bufferbloat.net" , Dave Taht , ath10k , make-wifi-fast@lists.bufferbloat.net On Thu, 2016-05-05 at 19:25 +0300, Roman Yeryomin wrote: > On 5 May 2016 at 19:12, Eric Dumazet wrote: > > On Thu, 2016-05-05 at 17:53 +0300, Roman Yeryomin wrote: > > > >> > >> qdisc fq_codel 0: dev eth0 root refcnt 2 limit 1024p flows 1024 > >> quantum 1514 target 5.0ms interval 100.0ms ecn > >> Sent 12306 bytes 128 pkt (dropped 0, overlimits 0 requeues 0) > >> backlog 0b 0p requeues 0 > >> maxpacket 0 drop_overlimit 0 new_flow_count 0 ecn_mark 0 > >> new_flows_len 0 old_flows_len 0 > > > > > > Limit of 1024 packets and 1024 flows is not wise I think. > > > > (If all buckets are in use, each bucket has a virtual queue of 1 packet, > > which is almost the same than having no queue at all) > > > > I suggest to have at least 8 packets per bucket, to let Codel have a > > chance to trigger. > > > > So you could either reduce number of buckets to 128 (if memory is > > tight), or increase limit to 8192. > > Will try, but what I've posted is default, I didn't change/configure that. fq_codel has a default of 10240 packets and 1024 buckets. http://lxr.free-electrons.com/source/net/sched/sch_fq_codel.c#L413 If someone changed that in the linux variant you use, he probably should explain the rationale. _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k