From: Taeung Song <treeze.taeung@gmail.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Taeung Song <treeze.taeung@gmail.com>
Subject: [PATCH 0/4] perf config: Introduce default config key-value pairs arrays
Date: Mon, 9 May 2016 20:41:45 +0900 [thread overview]
Message-ID: <1462794109-14652-1-git-send-email-treeze.taeung@gmail.com> (raw)
We currently use values of actual type(int, bool, char *, etc.)
when initializing default perf config values.
For example,
If there isn't user config value at ~/.perfconfig for 'annotate.use_offset' config variable,
default value for it is 'true' bool type value in perf like below.
At ui/browsers/annoate.c
static struct annotate_browser_opt {
bool hide_src_code,
use_offset,
jump_arrows,
show_linenr,
show_nr_jumps,
show_total_period;
} annotate_browser__opts = {
.use_offset = true,
.jump_arrows = true,
};
But I suggest using new config arrays that have all default config key-value pairs
and then initializing default config values with them.
Because if we do, we can manage default perf config values at one spot (like util/config.c)
and It can be easy and simple to modify default config values or add new configs.
For example,
If we use new default config arrays and there isn't user config value for 'annoate.use_offset'
default value for it will be set as annotate_config_items[CONFIG_ANNOATE_USE_OFFSET].value
instead of actual boolean type value 'true'.
IMHO, I think it should be needed to use new default config arrays
to manage default perf config values more effectively.
And this pathset contains patchs for only 'colors' and 'annoate' section
because waiting for other opinions.
If you review this patchset, I'd appreciate it :-)
Thanks,
Taeung
Taeung Song (4):
perf config: Introduce default_config_item for all default config
key-value pairs
perf tools: Separate out code setting ground colors from
ui_browser__color_config
perf config: Initialize ui_browser__colorsets with default config
items
perf config: Initialize annotate_browser__opts with default config
items
tools/perf/ui/browser.c | 89 ++++++++++++++--------
tools/perf/ui/browser.h | 1 +
tools/perf/ui/browsers/annotate.c | 12 ++-
tools/perf/ui/tui/setup.c | 1 +
tools/perf/util/cache.h | 1 +
tools/perf/util/config.c | 150 +++++++++++++++++++++++++++++++++++++-
tools/perf/util/config.h | 74 ++++++++++++++++++-
7 files changed, 291 insertions(+), 37 deletions(-)
--
2.5.0
next reply other threads:[~2016-05-09 11:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 11:41 Taeung Song [this message]
2016-05-09 11:41 ` [PATCH 1/4] perf config: Introduce default_config_item for all default config key-value pairs Taeung Song
2016-05-09 17:17 ` Arnaldo Carvalho de Melo
2016-05-10 11:49 ` Taeung Song
2016-05-10 15:05 ` Arnaldo Carvalho de Melo
2016-05-11 10:30 ` Taeung Song
2016-05-09 11:41 ` [PATCH 2/4] perf tools: Separate out code setting ground colors from ui_browser__color_config Taeung Song
2016-05-09 17:17 ` Arnaldo Carvalho de Melo
2016-05-10 11:33 ` Taeung Song
2016-05-09 11:41 ` [PATCH 3/4] perf config: Initialize ui_browser__colorsets with default config items Taeung Song
2016-05-09 17:19 ` Arnaldo Carvalho de Melo
2016-05-10 11:57 ` Taeung Song
2016-05-09 11:41 ` [PATCH 4/4] perf config: Initialize annotate_browser__opts " Taeung Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462794109-14652-1-git-send-email-treeze.taeung@gmail.com \
--to=treeze.taeung@gmail.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.