From: Elad Kanfi <eladkan@mellanox.com>
To: <davem@davemloft.net>
Cc: <noamca@mellanox.com>, <linux-kernel@vger.kernel.org>,
<abrodkin@synopsys.com>, <eladkan@mellanox.com>,
<netdev@vger.kernel.org>
Subject: [PATCH v3 0/2] Net driver bugs fix
Date: Mon, 9 May 2016 20:13:18 +0300 [thread overview]
Message-ID: <1462814000-16331-1-git-send-email-eladkan@mellanox.com> (raw)
From: Elad Kanfi <eladkan@mellanox.com>
v3:
tx_packet_sent flag is not necessary, use socket buffer pointer
instead.
Use wmb() instead of smp_wmb().
v2:
Remove code style commit for now.
Code style commit will be added after the bugs fix will be approved.
Summary:
1. Bug description: TX done interrupts that arrives while interrupts
are masked, during NAPI poll, will not trigger an interrupt handling.
Since TX interrupt is of level edge we will lose the TX done interrupt.
As a result all pending tx frames will get no service.
Solution: Check if there is a pending tx request after unmasking the
interrupt and if answer is yes then re-add ourselves to
the NAPI poll list.
2. Bug description: CPU-A before sending a frame will set a variable
to true. CPU-B that executes the tx done interrupt service routine
might read a non valid value of that variable.
Solution: Use the socket buffer pointer instead of the variable,
and add a write memory barrier at the tx sending function after
the pointer is set.
Elad Kanfi (2):
net: nps_enet: Tx handler synchronization
net: nps_enet: bug fix - handle lost tx interrupts
drivers/net/ethernet/ezchip/nps_enet.c | 30 ++++++++++++++++++++++++------
drivers/net/ethernet/ezchip/nps_enet.h | 2 --
2 files changed, 24 insertions(+), 8 deletions(-)
next reply other threads:[~2016-05-09 17:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 17:13 Elad Kanfi [this message]
2016-05-09 17:13 ` [PATCH v3 1/2] net: nps_enet: Tx handler synchronization Elad Kanfi
2016-05-09 17:13 ` [PATCH v3 2/2] net: nps_enet: bug fix - handle lost tx interrupts Elad Kanfi
2016-05-10 18:40 ` [PATCH v3 0/2] Net driver bugs fix David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462814000-16331-1-git-send-email-eladkan@mellanox.com \
--to=eladkan@mellanox.com \
--cc=abrodkin@synopsys.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noamca@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.