All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org, emmanuel.grumbach@intel.com
Subject: [PATCH 29/41] iwlwifi: mvm: remove redundant alloc_ctx parameter
Date: Tue, 10 May 2016 23:06:25 +0300	[thread overview]
Message-ID: <1462910797-20303-29-git-send-email-luca@coelho.fi> (raw)
In-Reply-To: <1462910797-20303-1-git-send-email-luca@coelho.fi>

From: Sara Sharon <sara.sharon@intel.com>

iwl_phy_db_set_section() is get called only from atomic
context, the alloc_ctx parameter is not needed. Remove it.

Signed-off-by: Sara Sharon <sara.sharon@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c | 6 +++---
 drivers/net/wireless/intel/iwlwifi/iwl-phy-db.h | 4 ++--
 drivers/net/wireless/intel/iwlwifi/mvm/fw.c     | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c b/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c
index ecfa491..7beba9a 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c
@@ -221,8 +221,8 @@ void iwl_phy_db_free(struct iwl_phy_db *phy_db)
 }
 IWL_EXPORT_SYMBOL(iwl_phy_db_free);
 
-int iwl_phy_db_set_section(struct iwl_phy_db *phy_db, struct iwl_rx_packet *pkt,
-			   gfp_t alloc_ctx)
+int iwl_phy_db_set_section(struct iwl_phy_db *phy_db,
+			   struct iwl_rx_packet *pkt)
 {
 	struct iwl_calib_res_notif_phy_db *phy_db_notif =
 			(struct iwl_calib_res_notif_phy_db *)pkt->data;
@@ -269,7 +269,7 @@ int iwl_phy_db_set_section(struct iwl_phy_db *phy_db, struct iwl_rx_packet *pkt,
 		return -EINVAL;
 
 	kfree(entry->data);
-	entry->data = kmemdup(phy_db_notif->data, size, alloc_ctx);
+	entry->data = kmemdup(phy_db_notif->data, size, GFP_ATOMIC);
 	if (!entry->data) {
 		entry->size = 0;
 		return -ENOMEM;
diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.h b/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.h
index 2410387..d34de3f 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.h
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.h
@@ -73,8 +73,8 @@ struct iwl_phy_db *iwl_phy_db_init(struct iwl_trans *trans);
 
 void iwl_phy_db_free(struct iwl_phy_db *phy_db);
 
-int iwl_phy_db_set_section(struct iwl_phy_db *phy_db, struct iwl_rx_packet *pkt,
-			   gfp_t alloc_ctx);
+int iwl_phy_db_set_section(struct iwl_phy_db *phy_db,
+			   struct iwl_rx_packet *pkt);
 
 
 int iwl_send_phy_db_data(struct iwl_phy_db *phy_db);
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
index b70f453..7057f35 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
@@ -535,7 +535,7 @@ static bool iwl_wait_phy_db_entry(struct iwl_notif_wait_data *notif_wait,
 		return true;
 	}
 
-	WARN_ON(iwl_phy_db_set_section(phy_db, pkt, GFP_ATOMIC));
+	WARN_ON(iwl_phy_db_set_section(phy_db, pkt));
 
 	return false;
 }
-- 
2.8.1


  parent reply	other threads:[~2016-05-10 20:31 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-10 20:03 pull-request: iwlwifi-next 2016-05-10 Luca Coelho
2016-05-10 20:05 ` [PATCH 01/41] iwlwifi: mvm: allocate queue for probe response in dqa mode Luca Coelho
2016-05-10 20:05   ` [PATCH 02/41] iwlwifi: mvm: support p2p device frames tx on dqa queue #2 Luca Coelho
2016-05-10 20:05   ` [PATCH 03/41] iwlwifi: Edit the 8265 SDIO ID Luca Coelho
2016-05-10 20:06   ` [PATCH 04/41] iwlwifi: mvm: implement driver RX queues sync command Luca Coelho
2016-05-10 20:06   ` [PATCH 05/41] iwlwifi: mvm: change RX sync notification to be an attribute and not a type Luca Coelho
2016-05-10 20:06   ` [PATCH 06/41] iwlwifi: mvm: add infrastructure for tracking BA session in driver Luca Coelho
2016-05-10 20:06   ` [PATCH 07/41] iwlwifi: mvm: add firmware API name comment Luca Coelho
2016-05-10 20:06   ` [PATCH 08/41] iwlwifi: mvm: add reorder buffer per queue Luca Coelho
2016-05-10 20:06   ` [PATCH 09/41] iwlwifi: mvm: add reorder timeout per frame Luca Coelho
2016-05-10 20:06   ` [PATCH 10/41] iwlwifi: mvm: utilize the frame release infrastructure Luca Coelho
2016-05-10 20:06   ` [PATCH 11/41] iwlwifi: mvm: support queue removal in ADD_STA hcmd Luca Coelho
2016-05-10 20:06   ` [PATCH 12/41] iwlwifi: trans: don't call the trans-specific ref/unref directly Luca Coelho
2016-05-11 16:34     ` Kalle Valo
2016-05-11 17:04       ` Luca Coelho
2016-05-10 20:06   ` [PATCH 13/41] iwlwifi: mvm: advertise RSS queue usage Luca Coelho
2016-05-10 20:06   ` [PATCH 14/41] iwlwifi: mvm: add a flag to disable checksum Luca Coelho
2016-05-10 20:06   ` [PATCH 15/41] iwlwifi: Rename 9560 to 9260 and add new PCI IDs for it Luca Coelho
2016-05-10 20:06   ` [PATCH 16/41] iwlwifi: mvm: allow a debug knob for Tx A-MSDU even if rate control forbids it Luca Coelho
2016-05-10 20:06   ` [PATCH 17/41] iwlwifi: wake from runtime suspend before sending sync commands Luca Coelho
2016-05-10 20:06   ` [PATCH 18/41] iwlwifi: allow combining different phy images with mac images Luca Coelho
2016-05-10 20:06   ` [PATCH 19/41] iwlwifi: consider VHT 160MHz while parsing NVM Luca Coelho
2016-05-10 20:06   ` [PATCH 20/41] iwlwifi: mvm: pass station to mac80211 RX where known Luca Coelho
2016-05-10 20:06   ` [PATCH 21/41] iwlwifi: mvm: add a new mvm reference type for RX data Luca Coelho
2016-05-10 20:06   ` [PATCH 22/41] iwlwifi: mvm: add more registers to dump upon error Luca Coelho
2016-05-10 20:06   ` [PATCH 23/41] iwlwifi: mvm: don't allow negative reference count Luca Coelho
2016-05-10 20:06   ` [PATCH 24/41] iwlwifi: Fix firmware name maximum length definition Luca Coelho
2016-05-10 20:06   ` [PATCH 25/41] iwlwifi: pcie: don't wake up the NIC when writing CSRs in MSIX mode Luca Coelho
2016-05-10 20:06   ` [PATCH 26/41] iwlwifi: mvm: loosen nssn comparison to reorder buffer head Luca Coelho
2016-05-10 20:06   ` [PATCH 27/41] iwlwifi: mvm: set correct vht capability Luca Coelho
2016-05-10 20:06   ` [PATCH 28/41] iwlwifi: mvm: make phy_db size dynamic Luca Coelho
2016-05-10 20:06   ` Luca Coelho [this message]
2016-05-10 20:06   ` [PATCH 30/41] iwlwifi: mvm: use helpers to get iwl_mvm_sta Luca Coelho
2016-05-10 20:06   ` [PATCH 31/41] iwlwifi: remove IWLWIFI_DEBUG_EXPERIMENTAL_UCODE Luca Coelho
2016-05-10 20:06   ` [PATCH 32/41] iwlwifi: don't access a nonexistent register upon assert Luca Coelho
2016-05-10 20:06   ` [PATCH 33/41] iwlwifi: make configuration structs smaller Luca Coelho
2016-05-10 20:06   ` [PATCH 34/41] iwlwifi: turn on SGI support for VHT 160MHz Luca Coelho
2016-05-10 20:06   ` [PATCH 35/41] iwlwifi: pcie: extend device reset delay Luca Coelho
2016-05-10 20:06   ` [PATCH 36/41] iwlwifi: pcie: avoid msleep() with short timeout Luca Coelho
2016-05-10 20:06   ` [PATCH 37/41] iwlwifi: mvm: support dqa-mode agg on non-shared queue Luca Coelho
2016-05-10 20:06   ` [PATCH 38/41] iwlwifi: pcie: use shadow registers for updating write pointer Luca Coelho
2016-05-10 20:06   ` [PATCH 39/41] iwlwifi: pcie: grab NIC access only once on RX init Luca Coelho
2016-05-10 20:06   ` [PATCH 40/41] iwlwifi: add default value to disable_11ac mod param description Luca Coelho
2016-05-10 20:06   ` [PATCH 41/41] MAINTAINERS: add myself as co-maintainer of the iwlwifi driver Luca Coelho
2016-05-11 17:56 ` pull-request: iwlwifi-next 2016-05-10 Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462910797-20303-29-git-send-email-luca@coelho.fi \
    --to=luca@coelho.fi \
    --cc=emmanuel.grumbach@intel.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.