All of lore.kernel.org
 help / color / mirror / Atom feed
From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>,
	Romain Naour <romain.naour@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/mesa3d: fix build on m68k
Date: Mon, 4 Oct 2021 17:23:23 +0200	[thread overview]
Message-ID: <1462D59B-55E2-4933-AD39-7EF25B2FBE9E@benettiengineering.com> (raw)
In-Reply-To: <20211004150113.GB1504958@scaer>

Hi Peter, Yann, All,

> Il giorno 4 ott 2021, alle ore 17:01, Yann E. MORIN <yann.morin.1998@free.fr> ha scritto:
> 
> Peter, Giulio, All,
> 
> On 2021-10-04 13:46 +0200, Peter Korsgaard spake thusly:
>>>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:
>> 
>>> To build mesa3d for m68k we need to pass -mlong-jump-table-offsets CFLAG
>>> since 'switch' blocks are pretty wide and lead to build failure. This way
>>> 'switch' blocks will have a 32-bit addressing by default instead of the
>>> standard 16-bit. This can be done only with m68k gcc version >= 7.x
>>> because gcc flag used to fix this(-mlong-jump-table-offsets) is
>>> available only from that version on.
>> 
>>> Fixes:
>>> http://autobuild.buildroot.net/results/60c4653c2a93125edbdd0beb43cd47301643464a/
>> 
>>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>>> ---
>>> V1-> V2:
>>> * add gcc >= 7.x dependency to Config.in as suggested by Yann Morin
>>> * improve commit log according to Config.in change
>> 
>> ..
>> 
>>> +# m68k needs 32-bit offsets in switch tables to build
>>> +ifeq ($(BR2_m68k),y)
>>> +MESA3D_CFLAGS += -mlong-jump-table-offsets
>>> +endif
>>> +
>>> +MESA3D_CONF_OPTS += -DCMAKE_C_FLAGS="$(MESA3D_CFLAGS)"
>>> +
>>> $(eval $(meson-package))
>> 
>> Does that really work? mesa3d is using meson, not cmake.
> 
> Apparently, no:
>    http://autobuild.buildroot.org/results/26a/26a97e080c49c42c06ed59ec6a9d51d81b0ab882/build-end.log

Strange, I’m going to fix it tonight. I don’t know how it could be, because I’m sure the solution works. Sorry

Giulio

> 
> Damn, not sure how I let this split through... :-/
> 
> Regards,
> Yann E. MORIN.
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2021-10-04 15:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14 22:10 [Buildroot] [PATCH] package/mesa3d: fix build on m68k Giulio Benetti
2021-09-18 12:47 ` Yann E. MORIN
2021-09-19  0:51   ` [Buildroot] [PATCH v2] " Giulio Benetti
2021-09-19  8:11     ` Yann E. MORIN
2021-10-04 11:46     ` Peter Korsgaard
2021-10-04 15:01       ` Yann E. MORIN
2021-10-04 15:23         ` Giulio Benetti [this message]
2021-10-04 20:35           ` Giulio Benetti
2021-10-04 20:37             ` Giulio Benetti
2021-09-19  0:53   ` [Buildroot] [PATCH] " Giulio Benetti
2021-09-19 11:49   ` Arnout Vandecappelle
2021-09-19 15:21     ` Giulio Benetti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462D59B-55E2-4933-AD39-7EF25B2FBE9E@benettiengineering.com \
    --to=giulio.benetti@benettiengineering.com \
    --cc=bernd.kuhls@t-online.de \
    --cc=buildroot@buildroot.org \
    --cc=romain.naour@gmail.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.