From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932189AbcELIug (ORCPT ); Thu, 12 May 2016 04:50:36 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33353 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752790AbcELIua (ORCPT ); Thu, 12 May 2016 04:50:30 -0400 From: Mathieu OTHACEHE To: johan@kernel.org Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Mathieu OTHACEHE Subject: [PATCH 17/36] usb: serial: ti_usb_3410_5052: Remove useless tty_wakeup Date: Thu, 12 May 2016 10:48:49 +0200 Message-Id: <1463042948-12205-18-git-send-email-m.othacehe@gmail.com> X-Mailer: git-send-email 2.8.2 In-Reply-To: <1463042948-12205-1-git-send-email-m.othacehe@gmail.com> References: <1463042948-12205-1-git-send-email-m.othacehe@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The generic driver doesn't call tty_wakeup in usb_serial_generic_msr_changed so this tty_wakeup seems useless. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c index 5ef721c..3f2372e 100644 --- a/drivers/usb/serial/ti_usb_3410_5052.c +++ b/drivers/usb/serial/ti_usb_3410_5052.c @@ -1238,7 +1238,6 @@ static int ti_set_serial_info(struct tty_struct *tty, struct ti_port *tport, static void ti_handle_new_msr(struct ti_port *tport, u8 msr) { struct async_icount *icount; - struct tty_struct *tty; unsigned long flags; dev_dbg(&tport->tp_port->dev, "%s - msr 0x%02X\n", __func__, msr); @@ -1259,14 +1258,6 @@ static void ti_handle_new_msr(struct ti_port *tport, u8 msr) } tport->tp_msr = msr & TI_MSR_MASK; - - /* handle CTS flow control */ - tty = tty_port_tty_get(&tport->tp_port->port); - if (tty && C_CRTSCTS(tty)) { - if (msr & TI_MSR_CTS) - tty_wakeup(tty); - } - tty_kref_put(tty); } static int ti_write_byte(struct usb_serial_port *port, -- 2.8.2