From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932290AbcELI6r (ORCPT ); Thu, 12 May 2016 04:58:47 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35764 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932147AbcELIud (ORCPT ); Thu, 12 May 2016 04:50:33 -0400 From: Mathieu OTHACEHE To: johan@kernel.org Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Mathieu OTHACEHE Subject: [PATCH 21/36] usb: serial: ti_usb_3410_5052: Use generic close function Date: Thu, 12 May 2016 10:48:53 +0200 Message-Id: <1463042948-12205-22-git-send-email-m.othacehe@gmail.com> X-Mailer: git-send-email 2.8.2 In-Reply-To: <1463042948-12205-1-git-send-email-m.othacehe@gmail.com> References: <1463042948-12205-1-git-send-email-m.othacehe@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use usb_serial_generic_close in close callback. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c index 8350c6b..3d36ae7 100644 --- a/drivers/usb/serial/ti_usb_3410_5052.c +++ b/drivers/usb/serial/ti_usb_3410_5052.c @@ -807,24 +807,16 @@ static void ti_close(struct usb_serial_port *port) { struct ti_device *tdev; struct ti_port *tport; - int port_number; int status; int do_unlock; - unsigned long flags; tdev = usb_get_serial_data(port->serial); tport = usb_get_serial_port_data(port); - usb_kill_urb(port->read_urb); - usb_kill_urb(port->write_urb); - spin_lock_irqsave(&tport->tp_lock, flags); - kfifo_reset_out(&port->write_fifo); - spin_unlock_irqrestore(&tport->tp_lock, flags); - - port_number = port->port_number; + usb_serial_generic_close(port); status = ti_send_ctrl_urb(port->serial, TI_CLOSE_PORT, 0, - TI_UART1_PORT + port_number); + TI_UART1_PORT + port->port_number); if (status) dev_err(&port->dev, "%s - cannot send close port command, %d\n" -- 2.8.2