From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1CHM-0005Mx-1Y for qemu-devel@nongnu.org; Fri, 13 May 2016 08:33:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b1CH7-0006iY-MU for qemu-devel@nongnu.org; Fri, 13 May 2016 08:33:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42927) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1CH7-0006iN-Ga for qemu-devel@nongnu.org; Fri, 13 May 2016 08:33:01 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 17F30263D for ; Fri, 13 May 2016 12:33:01 +0000 (UTC) From: Gerd Hoffmann Date: Fri, 13 May 2016 14:32:44 +0200 Message-Id: <1463142777-13040-5-git-send-email-kraxel@redhat.com> In-Reply-To: <1463142777-13040-1-git-send-email-kraxel@redhat.com> References: <1463142777-13040-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL v2 04/17] configure: error on unknown --with-sdlabi value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Cole Robinson , Gerd Hoffmann From: Cole Robinson I accidentally tried --with-sdlabi="1.0", and it failed much later in a weird way. Instead, throw an error if the value isn't in our whitelist. Signed-off-by: Cole Robinson Message-id: 60e4822e17697d257a914df03bdb9fff4b4c0490.1462557436.git.crobinso@redhat.com Signed-off-by: Gerd Hoffmann --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 0b53fac..8e25a24 100755 --- a/configure +++ b/configure @@ -2434,9 +2434,11 @@ if test $sdlabi = "2.0"; then sdl_config=$sdl2_config sdlname=sdl2 sdlconfigname=sdl2_config -else +elif test $sdlabi = "1.2"; then sdlname=sdl sdlconfigname=sdl_config +else + error_exit "Unknown sdlabi $sdlabi, must be 1.2 or 2.0" fi if test "`basename $sdl_config`" != $sdlconfigname && ! has ${sdl_config}; then -- 1.8.3.1