From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, nogahf@mellanox.com,
idosch@mellanox.com, eladr@mellanox.com, yotamg@mellanox.com,
ogerlitz@mellanox.com, roopa@cumulusnetworks.com,
nikolay@cumulusnetworks.com, linville@tuxdriver.com,
tgraf@suug.ch, gospo@cumulusnetworks.com, sfeldma@gmail.com,
sd@queasysnail.net, eranbe@mellanox.com, ast@plumgrid.com,
edumazet@google.com, hannes@stressinduktion.org,
f.fainelli@gmail.com
Subject: Re: [patch net-next v3 1/4] netdevice: add SW statistics ndo
Date: Fri, 13 May 2016 10:17:50 -0700 [thread overview]
Message-ID: <1463159870.23934.201.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <1463151257-3972-2-git-send-email-jiri@resnulli.us>
On Fri, 2016-05-13 at 16:54 +0200, Jiri Pirko wrote:
> From: Nogah Frankel <nogahf@mellanox.com>
]
> +bool dev_have_sw_stats(struct net_device *dev)
> +{
> + return (dev->netdev_ops->ndo_get_sw_stats64 != NULL);
> +}
> +EXPORT_SYMBOL(dev_have_sw_stats);
> +
2 things : const, and return is not a function.
bool dev_have_sw_stats(const struct net_device *dev)
{
return dev->netdev_ops->ndo_get_sw_stats64 != NULL;
}
next prev parent reply other threads:[~2016-05-13 17:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 14:54 [patch net-next v3 0/4] return offloaded stats as default and expose original sw start Jiri Pirko
2016-05-13 14:54 ` [patch net-next v3 1/4] netdevice: add SW statistics ndo Jiri Pirko
2016-05-13 17:17 ` Eric Dumazet [this message]
2016-05-13 14:54 ` [patch net-next v3 2/4] rtnetlink: add HW/SW stats distinction in rtnl_fill_stats Jiri Pirko
2016-05-13 17:20 ` Eric Dumazet
2016-05-13 14:54 ` [patch net-next v3 3/4] net: core: add SW stats to if_stats_msg Jiri Pirko
2016-05-13 14:54 ` [patch net-next v3 4/4] mlxsw: spectrum: Implement SW stats ndo and expose HW stats by default Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463159870.23934.201.camel@edumazet-glaptop3.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eladr@mellanox.com \
--cc=eranbe@mellanox.com \
--cc=f.fainelli@gmail.com \
--cc=gospo@cumulusnetworks.com \
--cc=hannes@stressinduktion.org \
--cc=idosch@mellanox.com \
--cc=jiri@resnulli.us \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=nogahf@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=roopa@cumulusnetworks.com \
--cc=sd@queasysnail.net \
--cc=sfeldma@gmail.com \
--cc=tgraf@suug.ch \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.