From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3fJp-0002y2-OA for qemu-devel@nongnu.org; Fri, 20 May 2016 03:58:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3fJo-00064o-Sk for qemu-devel@nongnu.org; Fri, 20 May 2016 03:58:01 -0400 From: Kevin Wolf Date: Fri, 20 May 2016 09:57:47 +0200 Message-Id: <1463731067-7120-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH] block: Fix memory leak in bdrv_next() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-devel@nongnu.org When all BDSes have already been iterated and we return NULL, the iterator must be freed, too. Signed-off-by: Kevin Wolf --- block/block-backend.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/block/block-backend.c b/block/block-backend.c index 6928d61..c5fb251 100644 --- a/block/block-backend.c +++ b/block/block-backend.c @@ -329,7 +329,12 @@ BdrvNextIterator *bdrv_next(BdrvNextIterator *it, BlockDriverState **bs) *bs = it->bs; } while (*bs && bdrv_has_blk(*bs)); - return *bs ? it : NULL; + if (*bs) { + return it; + } else { + g_free(it); + return NULL; + } } /* -- 1.8.3.1