All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: jpoimboe@redhat.com, mbenes@suse.cz, jeyu@redhat.com,
	jikos@kernel.org, jslaby@suse.cz
Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
	huawei.libin@huawei.com, minfei.huang@yahoo.com,
	Petr Mladek <pmladek@suse.com>
Subject: [RFC PATCH  0/2] livepatch: Avoid possible race when releasing the patch
Date: Mon, 23 May 2016 17:54:06 +0200	[thread overview]
Message-ID: <1464018848-4303-1-git-send-email-pmladek@suse.com> (raw)

There was a long discussion about a possible race with sysfs, kobjects
when removing an unused livepatch, see
https://lkml.kernel.org/g/%3C1462190242-24731-1-git-send-email-mbenes@suse.cz%3E

This patch set tries to implement what looked the most preferred solution
from the discussion. I did my best to keep the patch definition simple.
But I am not super happy with the result.

I send the current state before I spent even more time on different
approaches.

I personally think that we might get better result if we declare
some limited structures, define them statically and then copy all
data into the final structures in a single call. I did not implement
this because it was weird on the first look but I am not sure now.

But even more I would prefer the solution with the completion.
It is already used by the module framework. It does not look
that hacky to me after all.

See the comments in the second patch for more details.


This patch set has been tested against linux-next.


Petr Mladek (2):
  livepatch: Extend the livepatch-sample patch
  livepatch: Use kobjects the right way

 include/linux/livepatch.h            |  70 +++++--
 kernel/livepatch/core.c              | 355 +++++++++++++++++++++++------------
 samples/livepatch/livepatch-sample.c | 159 +++++++++++++---
 3 files changed, 425 insertions(+), 159 deletions(-)

-- 
1.8.5.6

             reply	other threads:[~2016-05-23 15:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-23 15:54 Petr Mladek [this message]
2016-05-23 15:54 ` [RFC PATCH 1/2] livepatch: Extend the livepatch-sample patch Petr Mladek
2016-05-23 15:54 ` [RFC PATCH 2/2] livepatch: Use kobjects the right way Petr Mladek
2016-05-23 16:30 ` [RFC PATCH 0/2] livepatch: Avoid possible race when releasing the patch Josh Poimboeuf
2016-05-23 21:35 ` Jessica Yu
2016-05-25  8:58   ` Miroslav Benes
2016-05-30 15:31     ` Petr Mladek
2016-05-31 18:40       ` Josh Poimboeuf
2016-05-31 19:00       ` Jessica Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464018848-4303-1-git-send-email-pmladek@suse.com \
    --to=pmladek@suse.com \
    --cc=huawei.libin@huawei.com \
    --cc=jeyu@redhat.com \
    --cc=jikos@kernel.org \
    --cc=jpoimboe@redhat.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=minfei.huang@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.