From: Andi Kleen <andi@firstfloor.org> To: acme@Kernel.org Cc: jolsa@Kernel.org, linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com> Subject: [PATCH 4/4] perf stat: Add missing aggregation headers for --metric-only CSV Date: Tue, 24 May 2016 12:52:39 -0700 [thread overview] Message-ID: <1464119559-17203-4-git-send-email-andi@firstfloor.org> (raw) In-Reply-To: <1464119559-17203-1-git-send-email-andi@firstfloor.org> From: Andi Kleen <ak@linux.intel.com> When in CSV mode --metric-only outputs an header, unlike the other modes. Previously it did not properly print headers for the aggregation columns, so the headers were actually shifted against the real values. Fix this here by outputting the correct headers for CSV. Acked-by: Jiri Olsa <jolsa@kernel.org v2: Indent array. Signed-off-by: Andi Kleen <ak@linux.intel.com> --- tools/perf/builtin-stat.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index c01fc7100dad..5a28976ae374 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -1316,6 +1316,14 @@ static int aggr_header_lens[] = { [AGGR_GLOBAL] = 0, }; +static const char *aggr_header_csv[] = { + [AGGR_CORE] = "core,cpus,", + [AGGR_SOCKET] = "socket,cpus", + [AGGR_NONE] = "cpu,", + [AGGR_THREAD] = "comm-pid,", + [AGGR_GLOBAL] = "" +}; + static void print_metric_headers(const char *prefix, bool no_indent) { struct perf_stat_output_ctx out; @@ -1330,6 +1338,12 @@ static void print_metric_headers(const char *prefix, bool no_indent) if (!csv_output && !no_indent) fprintf(stat_config.output, "%*s", aggr_header_lens[stat_config.aggr_mode], ""); + if (csv_output) { + if (stat_config.interval) + fputs("time,", stat_config.output); + fputs(aggr_header_csv[stat_config.aggr_mode], + stat_config.output); + } /* Print metrics headers only */ evlist__for_each(evsel_list, counter) { -- 2.5.5
next prev parent reply other threads:[~2016-05-24 19:52 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-05-24 19:52 [PATCH 1/4] perf stat: Basic support for TopDown in perf stat Andi Kleen 2016-05-24 19:52 ` [PATCH 2/4] perf stat: Add computation of TopDown formulas Andi Kleen 2016-06-01 14:50 ` Nilay Vaish 2016-06-01 14:56 ` Andi Kleen 2016-06-02 11:56 ` Nilay Vaish 2016-06-02 14:26 ` Andi Kleen 2016-06-08 8:39 ` [tip:perf/core] " tip-bot for Andi Kleen 2016-05-24 19:52 ` [PATCH 3/4] perf stat: Print topology/time headers with --metric-only Andi Kleen 2016-06-08 8:39 ` [tip:perf/core] " tip-bot for Andi Kleen 2016-05-24 19:52 ` Andi Kleen [this message] 2016-06-08 8:40 ` [tip:perf/core] perf stat: Add missing aggregation headers for --metric-only CSV tip-bot for Andi Kleen 2016-05-30 16:01 ` [PATCH 1/4] perf stat: Basic support for TopDown in perf stat Arnaldo Carvalho de Melo 2016-05-30 16:04 ` Andi Kleen 2016-05-30 16:19 ` Arnaldo Carvalho de Melo 2016-06-06 14:00 ` Arnaldo Carvalho de Melo 2016-06-06 14:11 ` Arnaldo Carvalho de Melo 2016-06-06 14:36 ` Andi Kleen 2016-06-01 14:24 ` Nilay Vaish 2016-06-01 14:31 ` Andi Kleen 2016-06-01 15:24 ` Andi Kleen 2016-06-02 11:52 ` Nilay Vaish 2016-06-08 8:38 ` [tip:perf/core] " tip-bot for Andi Kleen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1464119559-17203-4-git-send-email-andi@firstfloor.org \ --to=andi@firstfloor.org \ --cc=acme@Kernel.org \ --cc=ak@linux.intel.com \ --cc=jolsa@Kernel.org \ --cc=linux-kernel@vger.kernel.org \ --subject='Re: [PATCH 4/4] perf stat: Add missing aggregation headers for --metric-only CSV' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.