From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754137AbcEYJu1 (ORCPT ); Wed, 25 May 2016 05:50:27 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:34472 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753846AbcEYJuZ (ORCPT ); Wed, 25 May 2016 05:50:25 -0400 From: Caesar Wang To: daniel.lezcano@linaro.org, Heiko Stuebner Cc: dianders@chromium.org, briannorris@google.com, smbarber@google.com, linux-rockchip@lists.infradead.org, Thomas Gleixner , cf@rock-chips.com, huangtao@rock-chips.com, Caesar Wang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/5] clocksource: rockchip: remove unnecessary clear irq before request_irq Date: Wed, 25 May 2016 17:49:59 +0800 Message-Id: <1464169802-6033-3-git-send-email-wxt@rock-chips.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1464169802-6033-1-git-send-email-wxt@rock-chips.com> References: <1464169802-6033-1-git-send-email-wxt@rock-chips.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Huang Tao rk_timer_interrupt_clear and rk_timer_disable is unnecessary before request_irq. Timer should keep disabled before booting Linux. Signed-off-by: Huang Tao Cc: Daniel Lezcano Cc: Thomas Gleixner Cc: Heiko Stuebner Tested-by: Jianqun Xu Signed-off-by: Caesar Wang --- drivers/clocksource/rockchip_timer.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/clocksource/rockchip_timer.c b/drivers/clocksource/rockchip_timer.c index b991b28..b93fed6 100644 --- a/drivers/clocksource/rockchip_timer.c +++ b/drivers/clocksource/rockchip_timer.c @@ -158,9 +158,6 @@ static void __init rk_timer_init(struct device_node *np) ce->cpumask = cpumask_of(0); ce->rating = 250; - rk_timer_interrupt_clear(ce); - rk_timer_disable(ce); - ret = request_irq(irq, rk_timer_interrupt, IRQF_TIMER, TIMER_NAME, ce); if (ret) { pr_err("Failed to initialize '%s': %d\n", TIMER_NAME, ret); -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: wxt@rock-chips.com (Caesar Wang) Date: Wed, 25 May 2016 17:49:59 +0800 Subject: [PATCH 2/5] clocksource: rockchip: remove unnecessary clear irq before request_irq In-Reply-To: <1464169802-6033-1-git-send-email-wxt@rock-chips.com> References: <1464169802-6033-1-git-send-email-wxt@rock-chips.com> Message-ID: <1464169802-6033-3-git-send-email-wxt@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org From: Huang Tao rk_timer_interrupt_clear and rk_timer_disable is unnecessary before request_irq. Timer should keep disabled before booting Linux. Signed-off-by: Huang Tao Cc: Daniel Lezcano Cc: Thomas Gleixner Cc: Heiko Stuebner Tested-by: Jianqun Xu Signed-off-by: Caesar Wang --- drivers/clocksource/rockchip_timer.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/clocksource/rockchip_timer.c b/drivers/clocksource/rockchip_timer.c index b991b28..b93fed6 100644 --- a/drivers/clocksource/rockchip_timer.c +++ b/drivers/clocksource/rockchip_timer.c @@ -158,9 +158,6 @@ static void __init rk_timer_init(struct device_node *np) ce->cpumask = cpumask_of(0); ce->rating = 250; - rk_timer_interrupt_clear(ce); - rk_timer_disable(ce); - ret = request_irq(irq, rk_timer_interrupt, IRQF_TIMER, TIMER_NAME, ce); if (ret) { pr_err("Failed to initialize '%s': %d\n", TIMER_NAME, ret); -- 1.9.1