From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [ndctl PATCH] ndctl, list: display named devices by default
Date: Wed, 25 May 2016 23:42:42 +0000 [thread overview]
Message-ID: <1464219744.5653.3.camel@intel.com> (raw)
In-Reply-To: <146421880119.1718.16999953314573964681.stgit@dwillia2-desk3.amr.corp.intel.com>
On Wed, 2016-05-25 at 16:26 -0700, Dan Williams wrote:
> Instead of being silent when no list options are specified, default to
> list the device if it is the only parameter specified. For example,
> before:
>
> # ndctl list -d nmem0
> #
>
> ...after:
>
> # ndctl list -d nmem0
> {
> "dev":"nmem0",
> "id":"cdab-ffffffff"
> }
> #
>
> ...in other words omit the need for --dimms to be specified for this
> case.
>
> Reported-by: Vishal Verma <vishal.l.verma@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> ndctl/builtin-list.c | 17 ++++++++++++++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
Looks good!
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2016-05-25 23:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 23:26 [ndctl PATCH] ndctl, list: display named devices by default Dan Williams
2016-05-25 23:42 ` Verma, Vishal L [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464219744.5653.3.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.