All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geoff Levand <geoff@infradead.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/3] runc: new package
Date: Thu, 26 May 2016 12:51:49 -0700	[thread overview]
Message-ID: <1464292309.2374.38.camel@infradead.org> (raw)
In-Reply-To: <20160526211207.06e27be6@free-electrons.com>

Hi,

On Thu, 2016-05-26 at 21:12 +0200, Thomas Petazzoni wrote:
> On Wed, 25 May 2016 16:31:20 -0700, Christian Stewart wrote:
> +define RUNC_CONFIGURE_CMDS
> > +> > 	> > # Put sources at prescribed GOPATH location.
> > +> > 	> > export $(RUNC_MAKE_ENV) && \
> 
> What is the export doing here?
> 
> > +> > 	> > 	> > mkdir -p $$GOPATH/src/github.com/opencontainers && \
> > +> > 	> > 	> > ln -s $(@D) $$GOPATH/src/github.com/opencontainers/runc
> 
> There is no need for a && between those lines.
> 
> And why is this needed at all? What is this "prescribed GOPATH" thing ?

Go expects the developer to have a 'workspace' with a
prescribed directory layout.  Many projects archive their
sources with a truncated path, so when they are extracted
to a directory (@D in buildroot's case) things need to be
fix enough for the go compiler to work.  This is a common
situation, and these fixups are often seen in project
build scripts.

See https://golang.org/doc/code.html#Workspaces

-Geoff

  reply	other threads:[~2016-05-26 19:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-25 23:31 [Buildroot] [PATCH v3 0/3] Add docker engine support Christian Stewart
2016-05-25 23:31 ` [Buildroot] [PATCH v3 1/3] runc: new package Christian Stewart
2016-05-26 19:12   ` Thomas Petazzoni
2016-05-26 19:51     ` Geoff Levand [this message]
2016-05-26 20:01       ` Thomas Petazzoni
2016-05-26 20:21     ` Christian Stewart
2016-05-27  5:23       ` Thomas Petazzoni
2016-05-25 23:31 ` [Buildroot] [PATCH v3 2/3] docker-containerd: " Christian Stewart
2016-05-26 19:29   ` Thomas Petazzoni
2016-05-26 23:10     ` Christian Stewart
2016-05-25 23:31 ` [Buildroot] [PATCH v3 3/3] docker-engine: " Christian Stewart
2016-05-26 19:34   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464292309.2374.38.camel@infradead.org \
    --to=geoff@infradead.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.