From mboxrd@z Thu Jan 1 00:00:00 1970 From: Slawomir Mrozowicz Subject: [PATCH] enic: negative array index write Date: Fri, 27 May 2016 14:56:06 +0200 Message-ID: <1464353766-2404-1-git-send-email-slawomirx.mrozowicz@intel.com> Cc: dev@dpdk.org, Slawomir Mrozowicz To: johndale@cisco.com, neescoba@cisco.com Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 4081C5921 for ; Fri, 27 May 2016 13:56:33 +0200 (CEST) List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Negative array index write using variable pos as an index to array enic->fdir.nodes. Fixed by add array index check. Fixes: fefed3d1e62c ("enic: new driver") Coverity ID 13270 Signed-off-by: Slawomir Mrozowicz --- drivers/net/enic/enic_clsf.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/enic/enic_clsf.c b/drivers/net/enic/enic_clsf.c index edb56e1..6b1489d 100644 --- a/drivers/net/enic/enic_clsf.c +++ b/drivers/net/enic/enic_clsf.c @@ -213,6 +213,12 @@ int enic_fdir_add_fltr(struct enic *enic, struct rte_eth_fdir_filter *params) } pos = rte_hash_add_key(enic->fdir.hash, params); + if (pos < 0 || pos >= ENICPMD_FDIR_MAX) { + dev_err(enic, "Add hash key failed\n"); + enic->fdir.stats.f_add++; + return -EINVAL; + } + enic->fdir.nodes[pos] = key; return 0; } -- 1.9.1