All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Gamari <ben@smart-cactus.org>
To: "Pali Rohár" <pali.rohar@gmail.com>, linux-input@vger.kernel.org
Cc: Hans de Goede <hdegoede@redhat.com>,
	Allen Hung <Allen_Hung@dell.com>,
	Masaki Ota <masaki.ota@jp.alps.com>,
	Ben Morgan <Ben_Morgan@dell.com>,
	Ben Gamari <ben@smart-cactus.org>
Subject: [PATCH 2/4] input/alps: Handle 0-pressure 1F events
Date: Sat, 28 May 2016 14:01:00 +0200	[thread overview]
Message-ID: <1464436862-2649-3-git-send-email-ben@smart-cactus.org> (raw)
In-Reply-To: <1464436862-2649-1-git-send-email-ben@smart-cactus.org>

While a button is held SS5 hardware will give us single-finger packets
with x, y, and pressure equal to zero. This causes annoying jumps in
pointer position if a touch is released while the button is held. Handle
this by claiming zero contacts to ensure that no position events are
provided to the user.
---
 drivers/input/mouse/alps.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
index b8454af..7874f4f 100644
--- a/drivers/input/mouse/alps.c
+++ b/drivers/input/mouse/alps.c
@@ -1197,7 +1197,12 @@ static int alps_decode_ss4_v2(struct alps_fields *f,
 		f->mt[0].x = SS4_1F_X_V2(p);
 		f->mt[0].y = SS4_1F_Y_V2(p);
 		f->pressure = ((SS4_1F_Z_V2(p)) * 2) & 0x7f;
-		f->fingers = 1;
+		/*
+		 * When a button is held the device will give us events with x, y, and
+		 * pressure of 0. This causes annoying jumps if a touch is released while
+		 * the button is held. Handle this by claiming zero contacts.
+		 */
+		f->fingers = f->pressure > 0 ? 1 : 0;
 		f->first_mp = 0;
 		f->is_mp = 0;
 		break;
-- 
2.8.1


  parent reply	other threads:[~2016-05-28 12:01 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-28 12:00 [PATCH v2] Support for Alps SS5 touchpad Ben Gamari
2016-05-28 12:00 ` [PATCH 1/4] input/alps: Add touchstick support for SS5 hardware Ben Gamari
2016-06-13 13:47   ` Pali Rohár
2016-05-28 12:01 ` Ben Gamari [this message]
2016-06-13 13:49   ` [PATCH 2/4] input/alps: Handle 0-pressure 1F events Pali Rohár
2016-05-28 12:01 ` [PATCH 3/4] input/alps: Allow touchsticks to report pressure Ben Gamari
2016-05-28 12:40   ` Hans de Goede
2016-06-10 10:21     ` Ben Gamari
2016-06-10 10:57       ` Hans de Goede
2016-06-13  0:21         ` Peter Hutterer
2016-05-28 12:01 ` [PATCH 4/4] input/alps: Set DualPoint flag for 74 03 28 devices Ben Gamari
2016-05-30  9:11   ` Pali Rohár
2016-06-21  0:43     ` Dmitry Torokhov
2016-05-28 12:37 ` [PATCH v2] Support for Alps SS5 touchpad Hans de Goede
2016-05-28 13:16   ` Ben Gamari
2016-05-28 13:21     ` Hans de Goede
2016-05-30  9:13 ` Pali Rohár
2016-05-30  9:49   ` Ben Gamari
2016-06-20 17:48     ` Pali Rohár
2016-06-21  9:20       ` Ben Gamari
2016-06-29  9:46         ` Pali Rohár
2016-07-17 21:06           ` Ben Gamari
2016-07-17 21:42             ` Pali Rohár
2016-09-05  8:59 ` Pali Rohár
2016-09-06  3:38   ` Ben Gamari
2016-09-06  8:57     ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464436862-2649-3-git-send-email-ben@smart-cactus.org \
    --to=ben@smart-cactus.org \
    --cc=Allen_Hung@dell.com \
    --cc=Ben_Morgan@dell.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=masaki.ota@jp.alps.com \
    --cc=pali.rohar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.