From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933165AbcE3LcT (ORCPT ); Mon, 30 May 2016 07:32:19 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:58294 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933060AbcE3LcQ (ORCPT ); Mon, 30 May 2016 07:32:16 -0400 From: Vineet Gupta To: CC: , , , , , , , Vineet Gupta Subject: [PATCH-REBASED 1/2] tools/perf: Handle EOPNOTSUPP for sampling events Date: Mon, 30 May 2016 17:01:45 +0530 Message-ID: <1464607906-16012-2-git-send-email-vgupta@synopsys.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1464607906-16012-1-git-send-email-vgupta@synopsys.com> References: <1464607906-16012-1-git-send-email-vgupta@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.12.197.158] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This allows (with next change to perf core) for calling out in userspace the exact reason for perf record failing when PMU doesn't support overflow interrupts Signed-off-by: Vineet Gupta --- tools/perf/util/evsel.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 5d7037ef7d3b..1578e67c7357 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -2372,6 +2372,13 @@ int perf_evsel__open_strerror(struct perf_evsel *evsel, struct target *target, "No such device - did you specify an out-of-range profile CPU?"); break; case EOPNOTSUPP: + /* + * Needs to be tested ahead of precise_ip check as + * that seems to be true for this case as well + */ + if (evsel->attr.sample_period != 0) + return scnprintf(msg, size, "%s", + "PMU Hardware doesn't support sampling/overflow-interrupts."); if (evsel->attr.precise_ip) return scnprintf(msg, size, "%s", "\'precise\' request may not be supported. Try removing 'p' modifier."); -- 2.5.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vineet Gupta Subject: [PATCH-REBASED 1/2] tools/perf: Handle EOPNOTSUPP for sampling events Date: Mon, 30 May 2016 17:01:45 +0530 Message-ID: <1464607906-16012-2-git-send-email-vgupta@synopsys.com> References: <1464607906-16012-1-git-send-email-vgupta@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:58294 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933060AbcE3LcQ (ORCPT ); Mon, 30 May 2016 07:32:16 -0400 In-Reply-To: <1464607906-16012-1-git-send-email-vgupta@synopsys.com> Sender: linux-perf-users-owner@vger.kernel.org List-ID: To: linux-perf-users@vger.kernel.org Cc: peterz@infradead.org, acme@redhat.com, linux-kernel@vger.kernel.org, mingo@kernel.org, vincent.weaver@maine.edu, linux-snps-arc@lists.infradead.org, Alexey.Brodkin@synopsys.com, Vineet Gupta This allows (with next change to perf core) for calling out in userspace the exact reason for perf record failing when PMU doesn't support overflow interrupts Signed-off-by: Vineet Gupta --- tools/perf/util/evsel.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 5d7037ef7d3b..1578e67c7357 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -2372,6 +2372,13 @@ int perf_evsel__open_strerror(struct perf_evsel *evsel, struct target *target, "No such device - did you specify an out-of-range profile CPU?"); break; case EOPNOTSUPP: + /* + * Needs to be tested ahead of precise_ip check as + * that seems to be true for this case as well + */ + if (evsel->attr.sample_period != 0) + return scnprintf(msg, size, "%s", + "PMU Hardware doesn't support sampling/overflow-interrupts."); if (evsel->attr.precise_ip) return scnprintf(msg, size, "%s", "\'precise\' request may not be supported. Try removing 'p' modifier."); -- 2.5.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vineet.Gupta1@synopsys.com (Vineet Gupta) Date: Mon, 30 May 2016 17:01:45 +0530 Subject: [PATCH-REBASED 1/2] tools/perf: Handle EOPNOTSUPP for sampling events In-Reply-To: <1464607906-16012-1-git-send-email-vgupta@synopsys.com> References: <1464607906-16012-1-git-send-email-vgupta@synopsys.com> List-ID: Message-ID: <1464607906-16012-2-git-send-email-vgupta@synopsys.com> To: linux-snps-arc@lists.infradead.org This allows (with next change to perf core) for calling out in userspace the exact reason for perf record failing when PMU doesn't support overflow interrupts Signed-off-by: Vineet Gupta --- tools/perf/util/evsel.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 5d7037ef7d3b..1578e67c7357 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -2372,6 +2372,13 @@ int perf_evsel__open_strerror(struct perf_evsel *evsel, struct target *target, "No such device - did you specify an out-of-range profile CPU?"); break; case EOPNOTSUPP: + /* + * Needs to be tested ahead of precise_ip check as + * that seems to be true for this case as well + */ + if (evsel->attr.sample_period != 0) + return scnprintf(msg, size, "%s", + "PMU Hardware doesn't support sampling/overflow-interrupts."); if (evsel->attr.precise_ip) return scnprintf(msg, size, "%s", "\'precise\' request may not be supported. Try removing 'p' modifier."); -- 2.5.0