From: Minchan Kim <minchan@kernel.org> To: Andrew Morton <akpm@linux-foundation.org> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Minchan Kim <minchan@kernel.org>, Sergey Senozhatsky <sergey.senozhatsky@gmail.com> Subject: [PATCH v7 12/12] zram: use __GFP_MOVABLE for memory allocation Date: Wed, 1 Jun 2016 08:21:21 +0900 [thread overview] Message-ID: <1464736881-24886-13-git-send-email-minchan@kernel.org> (raw) In-Reply-To: <1464736881-24886-1-git-send-email-minchan@kernel.org> Zsmalloc is ready for page migration so zram can use __GFP_MOVABLE from now on. I did test to see how it helps to make higher order pages. Test scenario is as follows. KVM guest, 1G memory, ext4 formated zram block device, for i in `seq 1 8`; do dd if=/dev/vda1 of=mnt/test$i.txt bs=128M count=1 & done wait `pidof dd` for i in `seq 1 2 8`; do rm -rf mnt/test$i.txt done fstrim -v mnt echo "init" cat /proc/buddyinfo echo "compaction" echo 1 > /proc/sys/vm/compact_memory cat /proc/buddyinfo old: init Node 0, zone DMA 208 120 51 41 11 0 0 0 0 0 0 Node 0, zone DMA32 16380 13777 9184 3805 789 54 3 0 0 0 0 compaction Node 0, zone DMA 132 82 40 39 16 2 1 0 0 0 0 Node 0, zone DMA32 5219 5526 4969 3455 1831 677 139 15 0 0 0 new: init Node 0, zone DMA 379 115 97 19 2 0 0 0 0 0 0 Node 0, zone DMA32 18891 16774 10862 3947 637 21 0 0 0 0 0 compaction 1 Node 0, zone DMA 214 66 87 29 10 3 0 0 0 0 0 Node 0, zone DMA32 1612 3139 3154 2469 1745 990 384 94 7 0 0 As you can see, compaction made so many high-order pages. Yay! Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> Signed-off-by: Minchan Kim <minchan@kernel.org> --- drivers/block/zram/zram_drv.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 8fcad8b761f1..ccf1bddd09ca 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -732,7 +732,8 @@ static int zram_bvec_write(struct zram *zram, struct bio_vec *bvec, u32 index, handle = zs_malloc(meta->mem_pool, clen, __GFP_KSWAPD_RECLAIM | __GFP_NOWARN | - __GFP_HIGHMEM); + __GFP_HIGHMEM | + __GFP_MOVABLE); if (!handle) { zcomp_strm_release(zram->comp, zstrm); zstrm = NULL; @@ -740,7 +741,8 @@ static int zram_bvec_write(struct zram *zram, struct bio_vec *bvec, u32 index, atomic64_inc(&zram->stats.writestall); handle = zs_malloc(meta->mem_pool, clen, - GFP_NOIO | __GFP_HIGHMEM); + GFP_NOIO | __GFP_HIGHMEM | + __GFP_MOVABLE); if (handle) goto compress_again; -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org> To: Andrew Morton <akpm@linux-foundation.org> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Minchan Kim <minchan@kernel.org>, Sergey Senozhatsky <sergey.senozhatsky@gmail.com> Subject: [PATCH v7 12/12] zram: use __GFP_MOVABLE for memory allocation Date: Wed, 1 Jun 2016 08:21:21 +0900 [thread overview] Message-ID: <1464736881-24886-13-git-send-email-minchan@kernel.org> (raw) In-Reply-To: <1464736881-24886-1-git-send-email-minchan@kernel.org> Zsmalloc is ready for page migration so zram can use __GFP_MOVABLE from now on. I did test to see how it helps to make higher order pages. Test scenario is as follows. KVM guest, 1G memory, ext4 formated zram block device, for i in `seq 1 8`; do dd if=/dev/vda1 of=mnt/test$i.txt bs=128M count=1 & done wait `pidof dd` for i in `seq 1 2 8`; do rm -rf mnt/test$i.txt done fstrim -v mnt echo "init" cat /proc/buddyinfo echo "compaction" echo 1 > /proc/sys/vm/compact_memory cat /proc/buddyinfo old: init Node 0, zone DMA 208 120 51 41 11 0 0 0 0 0 0 Node 0, zone DMA32 16380 13777 9184 3805 789 54 3 0 0 0 0 compaction Node 0, zone DMA 132 82 40 39 16 2 1 0 0 0 0 Node 0, zone DMA32 5219 5526 4969 3455 1831 677 139 15 0 0 0 new: init Node 0, zone DMA 379 115 97 19 2 0 0 0 0 0 0 Node 0, zone DMA32 18891 16774 10862 3947 637 21 0 0 0 0 0 compaction 1 Node 0, zone DMA 214 66 87 29 10 3 0 0 0 0 0 Node 0, zone DMA32 1612 3139 3154 2469 1745 990 384 94 7 0 0 As you can see, compaction made so many high-order pages. Yay! Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> Signed-off-by: Minchan Kim <minchan@kernel.org> --- drivers/block/zram/zram_drv.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 8fcad8b761f1..ccf1bddd09ca 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -732,7 +732,8 @@ static int zram_bvec_write(struct zram *zram, struct bio_vec *bvec, u32 index, handle = zs_malloc(meta->mem_pool, clen, __GFP_KSWAPD_RECLAIM | __GFP_NOWARN | - __GFP_HIGHMEM); + __GFP_HIGHMEM | + __GFP_MOVABLE); if (!handle) { zcomp_strm_release(zram->comp, zstrm); zstrm = NULL; @@ -740,7 +741,8 @@ static int zram_bvec_write(struct zram *zram, struct bio_vec *bvec, u32 index, atomic64_inc(&zram->stats.writestall); handle = zs_malloc(meta->mem_pool, clen, - GFP_NOIO | __GFP_HIGHMEM); + GFP_NOIO | __GFP_HIGHMEM | + __GFP_MOVABLE); if (handle) goto compress_again; -- 1.9.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-05-31 23:22 UTC|newest] Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-05-31 23:21 [PATCH v7 00/12] Support non-lru page migration Minchan Kim 2016-05-31 23:21 ` Minchan Kim 2016-05-31 23:21 ` [PATCH v7 01/12] mm: use put_page to free page instead of putback_lru_page Minchan Kim 2016-05-31 23:21 ` Minchan Kim 2016-05-31 23:21 ` [PATCH v7 02/12] mm: migrate: support non-lru movable page migration Minchan Kim 2016-05-31 23:21 ` Minchan Kim 2016-05-31 23:21 ` Minchan Kim 2016-05-31 23:21 ` [PATCH v7 03/12] mm: balloon: use general non-lru movable page feature Minchan Kim 2016-05-31 23:21 ` Minchan Kim 2016-05-31 23:21 ` Minchan Kim 2016-05-31 23:21 ` [PATCH v7 04/12] zsmalloc: keep max_object in size_class Minchan Kim 2016-05-31 23:21 ` Minchan Kim 2016-05-31 23:21 ` [PATCH v7 05/12] zsmalloc: use bit_spin_lock Minchan Kim 2016-05-31 23:21 ` Minchan Kim 2016-05-31 23:21 ` [PATCH v7 06/12] zsmalloc: use accessor Minchan Kim 2016-05-31 23:21 ` Minchan Kim 2016-05-31 23:21 ` [PATCH v7 07/12] zsmalloc: factor page chain functionality out Minchan Kim 2016-05-31 23:21 ` Minchan Kim 2016-05-31 23:21 ` [PATCH v7 08/12] zsmalloc: introduce zspage structure Minchan Kim 2016-05-31 23:21 ` Minchan Kim 2016-05-31 23:21 ` [PATCH v7 09/12] zsmalloc: separate free_zspage from putback_zspage Minchan Kim 2016-05-31 23:21 ` Minchan Kim 2016-05-31 23:21 ` [PATCH v7 10/12] zsmalloc: use freeobj for index Minchan Kim 2016-05-31 23:21 ` Minchan Kim 2016-05-31 23:21 ` [PATCH v7 11/12] zsmalloc: page migration support Minchan Kim 2016-05-31 23:21 ` Minchan Kim 2016-06-01 14:09 ` Vlastimil Babka 2016-06-01 14:09 ` Vlastimil Babka 2016-06-02 0:25 ` Minchan Kim 2016-06-02 0:25 ` Minchan Kim 2016-06-02 11:44 ` Vlastimil Babka 2016-06-02 11:44 ` Vlastimil Babka 2016-06-01 21:39 ` Andrew Morton 2016-06-01 21:39 ` Andrew Morton 2016-06-02 0:15 ` Minchan Kim 2016-06-02 0:15 ` Minchan Kim [not found] ` <CGME20170119001317epcas1p188357c77e1f4ff08b6d3dcb76dedca06@epcas1p1.samsung.com> 2017-01-19 0:13 ` Chulmin Kim 2017-01-19 2:44 ` Minchan Kim 2017-01-19 3:39 ` Chulmin Kim 2017-01-19 6:21 ` Minchan Kim 2017-01-19 8:16 ` Chulmin Kim 2017-01-23 5:22 ` Minchan Kim 2017-01-23 5:30 ` Sergey Senozhatsky 2017-01-23 5:40 ` Minchan Kim 2017-01-25 4:06 ` Chulmin Kim 2017-01-25 4:25 ` Sergey Senozhatsky 2017-01-25 5:26 ` Minchan Kim 2017-01-26 17:04 ` Dan Streetman 2017-01-31 0:10 ` Minchan Kim 2017-01-31 13:09 ` Dan Streetman 2017-02-01 6:51 ` Minchan Kim 2017-02-01 19:38 ` Dan Streetman 2017-02-02 8:48 ` Minchan Kim 2016-05-31 23:21 ` Minchan Kim [this message] 2016-05-31 23:21 ` [PATCH v7 12/12] zram: use __GFP_MOVABLE for memory allocation Minchan Kim 2016-06-01 21:41 ` [PATCH v7 00/12] Support non-lru page migration Andrew Morton 2016-06-01 21:41 ` Andrew Morton 2016-06-01 21:41 ` Andrew Morton 2016-06-01 22:40 ` Daniel Vetter 2016-06-01 22:40 ` Daniel Vetter 2016-06-01 22:40 ` Daniel Vetter 2016-06-02 0:36 ` Minchan Kim 2016-06-02 0:36 ` Minchan Kim 2016-06-02 0:36 ` Minchan Kim 2016-06-15 7:59 ` Sergey Senozhatsky 2016-06-15 7:59 ` Sergey Senozhatsky 2016-06-15 7:59 ` Sergey Senozhatsky 2016-06-15 23:12 ` Minchan Kim 2016-06-15 23:12 ` Minchan Kim 2016-06-16 2:48 ` Sergey Senozhatsky 2016-06-16 2:48 ` Sergey Senozhatsky 2016-06-16 2:58 ` Minchan Kim 2016-06-16 2:58 ` Minchan Kim 2016-06-16 2:58 ` Minchan Kim 2016-06-16 4:23 ` Sergey Senozhatsky 2016-06-16 4:23 ` Sergey Senozhatsky 2016-06-16 4:47 ` Minchan Kim 2016-06-16 4:47 ` Minchan Kim 2016-06-16 4:47 ` Minchan Kim 2016-06-16 5:22 ` Sergey Senozhatsky 2016-06-16 5:22 ` Sergey Senozhatsky 2016-06-16 5:22 ` Sergey Senozhatsky 2016-06-16 6:47 ` Minchan Kim 2016-06-16 6:47 ` Minchan Kim 2016-06-16 6:47 ` Minchan Kim 2016-06-16 8:42 ` Sergey Senozhatsky 2016-06-16 8:42 ` Sergey Senozhatsky 2016-06-16 10:09 ` Minchan Kim 2016-06-16 10:09 ` Minchan Kim 2016-06-17 7:28 ` Joonsoo Kim 2016-06-17 7:28 ` Joonsoo Kim 2016-06-17 7:28 ` Joonsoo Kim 2016-06-16 10:09 ` Minchan Kim 2016-06-16 8:42 ` Sergey Senozhatsky 2016-06-16 4:23 ` Sergey Senozhatsky 2016-06-16 2:48 ` Sergey Senozhatsky 2016-06-15 23:12 ` Minchan Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1464736881-24886-13-git-send-email-minchan@kernel.org \ --to=minchan@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=sergey.senozhatsky@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.