From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757288AbcFAFHT (ORCPT ); Wed, 1 Jun 2016 01:07:19 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:35230 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753913AbcFAFHR (ORCPT ); Wed, 1 Jun 2016 01:07:17 -0400 Message-ID: <1464757633.4023.39.camel@gmail.com> Subject: Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up From: Mike Galbraith To: Yuyang Du , Peter Zijlstra Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, bsegall@google.com, pjt@google.com, morten.rasmussen@arm.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com Date: Wed, 01 Jun 2016 07:07:13 +0200 In-Reply-To: <20160531013132.GQ18670@intel.com> References: <1464657098-24880-1-git-send-email-yuyang.du@intel.com> <1464657098-24880-2-git-send-email-yuyang.du@intel.com> <20160531092146.GT3192@twins.programming.kicks-ass.net> <20160531013132.GQ18670@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-05-31 at 09:31 +0800, Yuyang Du wrote: > On Tue, May 31, 2016 at 11:21:46AM +0200, Peter Zijlstra wrote: > > On Tue, May 31, 2016 at 09:11:37AM +0800, Yuyang Du wrote: > > > The SD_BALANCE_WAKE is irrelevant in the contexts of these two removals, > > > and in addition SD_BALANCE_WAKE is not and should not be set in any > > > sched_domain flags so far. > > > > This Changelog doesn't make any sense... > > How? SD_BALANCE_WAKE is not in any sched_domain flags (sd->flags), even if > it is, it is not used anywhere, no? If the user chooses to set SD_BALANCE_WAKE in sd->flags, it is in fact used. It's just not turned on by default due to full balance on every wakeup being far too painful to do by default. -Mike