From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757535AbcFAIC4 (ORCPT ); Wed, 1 Jun 2016 04:02:56 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:26276 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750842AbcFAICr (ORCPT ); Wed, 1 Jun 2016 04:02:47 -0400 X-AuditID: cbfec7f4-f796c6d000001486-3c-574e96a383ec From: Krzysztof Kozlowski To: hzpeterchen@gmail.com, Ulf Hansson , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Krzysztof Kozlowski , Javier Martinez Canillas , linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-pm@vger.kernel.or, Alan Stern , linux-usb@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Greg Kroah-Hartman , Bartlomiej Zolnierkiewicz Subject: [PATCH v3 00/12] usb/mmc/power: Generic power sequence (and fix USB/LAN when TFTP booting) Date: Wed, 01 Jun 2016 10:02:09 +0200 Message-id: <1464768141-25420-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCLMWRmVeSWpSXmKPExsVy+t/xq7qLp/mFG7zYqW+xccZ6VotJT94z W8w/co7VYuLKycwW/W8Wslo0L17PZtF1dRObxblXKxkt3rxdw2Tx+oWhRf/j18wWmx5fY7W4 vGsOm8WR//2MFjMvrmaxmHF+H5PFomWtzBZLr19kspgwfS2LReveI+wWp3eXWEz4fYHN4vja cAdxjzXz1jB6XO7rZfLYOesuu8fK5V/YPDav0PLYtKqTzePOtT1sHvvnrmH32Lyk3mNLP1DB 7Ls/GD36tqxi9DjydTqLx+dNcgF8UVw2Kak5mWWpRfp2CVwZK9dfYi7oVqq4u3oLawPjZYku Rk4OCQETiYcfDzND2GISF+6tZ+ti5OIQEljKKHG17SoLhNPIJHH9wClWkCo2AWOJzcuXgFWJ CHSwSWza+oYdJMEskC1x6t57oCIODmGBVIk9nUkgYRYBVYlbx9eBlfAKuEu8X3uOFWKbnMTJ Y5NZJzByL2BkWMUomlqaXFCclJ5rqFecmFtcmpeul5yfu4kREhdfdjAuPmZ1iFGAg1GJh1fh om+4EGtiWXFl7iFGCQ5mJRFewcl+4UK8KYmVValF+fFFpTmpxYcYpTlYlMR55+56HyIkkJ5Y kpqdmlqQWgSTZeLglGpgTFPfUM44Q/8y64I9rc8Tb3d2+J7a+Vf2pv7jsz9Nm3ebHymLbBfJ XfDUxf2lc9IN28C08Lkx+v5LVn5eXnRcT61/QsuEd6vXTvc7s1LgkscKldQf9/M8nuopCDHe nLdsWv/vZeUVD+N+P8tXfXpjcfW7w/1qu3ybNCxKu28LTuq3f96TGN3opsRSnJFoqMVcVJwI AEfPwOaHAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, My third approach for a USB power sequence which fixes usb3503+lan on Odroid U3 board if it was initialized by bootloader (e.g. for TFTP boot). Changes since v2 ================ 1. Add Javier's reviewed-by tags. Address some comments. 2. Re-use existing properties for GPIOs etc by pwrseq-simple driver. New property is still added: "power-sequence". I tried to address and do according to Rob's comments. Please look at patch 6/12 ("power: pwrseq: simple: Add support for regulator and generic property") for bindings and the new code around matching "power-sequence" property. 3. I marked the usb code as "EXAMPLE" because that part is left to Peter Chen. Problem ======= When Odroid U3 (usb3503 + smsc95xx + max77686) boots from network (TFTP), the usb3503 and LAN smsc95xx do not show up in "lsusb". Hard-reset is required, e.g. by suspend to RAM. The actual TFTP boot does not have to happen. Just "usb start" from U-Boot is sufficient. >>From the schematics, the regulator is a supply only to LAN, however without toggling it off/on, the usb3503 hub won appear neither. Solution ======== This is very similar to the MMC pwrseq behavior so the idea is to: 1. Move MMC pwrseq drivers to generic place, 2. Extend the pwrseq-simple with regulator toggling, 3. Add support to USB hub and port core for pwrseq, 4. Toggle the regulator when needed. Best regards, Krzysztof Krzysztof Kozlowski (12): power/mmc: Move pwrseq drivers to power/pwrseq MAINTAINERS: Retain Ulf Hansson as the same maintainer of pwrseq power: pwrseq: Enable COMPILE_TEST for drivers power: pwrseq: Remove mmc prefix from mmc_pwrseq power: pwrseq: Generalize mmc_pwrseq operations by removing mmc prefix power: pwrseq: simple: Add support for regulator and generic property power: pwrseq: Add support for USB hubs with external power usb: hub: Handle deferred probe EXAMPLE CODE: usb: port: Parse pwrseq phandle from Device Tree EXAMPLE CODE: usb: hub: Power sequence the ports on activation ARM: dts: exynos: Switch the buck8 to GPIO mode on Odroid U3 ARM: dts: exynos: Fix LAN and HUB after bootloader initialization on Odroid U3 .../pwrseq/pwrseq-emmc.txt} | 0 .../pwrseq/pwrseq-simple.txt} | 29 +++- MAINTAINERS | 9 ++ arch/arm/boot/dts/exynos4412-odroidu3.dts | 5 + drivers/mmc/Kconfig | 2 - drivers/mmc/core/Makefile | 3 - drivers/mmc/core/core.c | 8 +- drivers/mmc/core/host.c | 2 +- drivers/mmc/core/pwrseq.c | 110 --------------- drivers/mmc/core/pwrseq.h | 52 ------- drivers/power/Kconfig | 1 + drivers/power/Makefile | 1 + drivers/{mmc/core => power/pwrseq}/Kconfig | 22 ++- drivers/power/pwrseq/Makefile | 3 + drivers/power/pwrseq/pwrseq.c | 153 +++++++++++++++++++++ drivers/{mmc/core => power/pwrseq}/pwrseq_emmc.c | 17 +-- drivers/{mmc/core => power/pwrseq}/pwrseq_simple.c | 110 ++++++++++++--- drivers/usb/core/hub.c | 16 ++- drivers/usb/core/hub.h | 3 + drivers/usb/core/port.c | 15 ++ include/linux/mmc/host.h | 4 +- include/linux/pwrseq.h | 63 +++++++++ 22 files changed, 414 insertions(+), 214 deletions(-) rename Documentation/devicetree/bindings/{mmc/mmc-pwrseq-emmc.txt => power/pwrseq/pwrseq-emmc.txt} (100%) rename Documentation/devicetree/bindings/{mmc/mmc-pwrseq-simple.txt => power/pwrseq/pwrseq-simple.txt} (53%) delete mode 100644 drivers/mmc/core/pwrseq.c delete mode 100644 drivers/mmc/core/pwrseq.h rename drivers/{mmc/core => power/pwrseq}/Kconfig (60%) create mode 100644 drivers/power/pwrseq/Makefile create mode 100644 drivers/power/pwrseq/pwrseq.c rename drivers/{mmc/core => power/pwrseq}/pwrseq_emmc.c (88%) rename drivers/{mmc/core => power/pwrseq}/pwrseq_simple.c (52%) create mode 100644 include/linux/pwrseq.h -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Wed, 01 Jun 2016 10:02:09 +0200 Subject: [PATCH v3 00/12] usb/mmc/power: Generic power sequence (and fix USB/LAN when TFTP booting) Message-ID: <1464768141-25420-1-git-send-email-k.kozlowski@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, My third approach for a USB power sequence which fixes usb3503+lan on Odroid U3 board if it was initialized by bootloader (e.g. for TFTP boot). Changes since v2 ================ 1. Add Javier's reviewed-by tags. Address some comments. 2. Re-use existing properties for GPIOs etc by pwrseq-simple driver. New property is still added: "power-sequence". I tried to address and do according to Rob's comments. Please look at patch 6/12 ("power: pwrseq: simple: Add support for regulator and generic property") for bindings and the new code around matching "power-sequence" property. 3. I marked the usb code as "EXAMPLE" because that part is left to Peter Chen. Problem ======= When Odroid U3 (usb3503 + smsc95xx + max77686) boots from network (TFTP), the usb3503 and LAN smsc95xx do not show up in "lsusb". Hard-reset is required, e.g. by suspend to RAM. The actual TFTP boot does not have to happen. Just "usb start" from U-Boot is sufficient. >>From the schematics, the regulator is a supply only to LAN, however without toggling it off/on, the usb3503 hub won appear neither. Solution ======== This is very similar to the MMC pwrseq behavior so the idea is to: 1. Move MMC pwrseq drivers to generic place, 2. Extend the pwrseq-simple with regulator toggling, 3. Add support to USB hub and port core for pwrseq, 4. Toggle the regulator when needed. Best regards, Krzysztof Krzysztof Kozlowski (12): power/mmc: Move pwrseq drivers to power/pwrseq MAINTAINERS: Retain Ulf Hansson as the same maintainer of pwrseq power: pwrseq: Enable COMPILE_TEST for drivers power: pwrseq: Remove mmc prefix from mmc_pwrseq power: pwrseq: Generalize mmc_pwrseq operations by removing mmc prefix power: pwrseq: simple: Add support for regulator and generic property power: pwrseq: Add support for USB hubs with external power usb: hub: Handle deferred probe EXAMPLE CODE: usb: port: Parse pwrseq phandle from Device Tree EXAMPLE CODE: usb: hub: Power sequence the ports on activation ARM: dts: exynos: Switch the buck8 to GPIO mode on Odroid U3 ARM: dts: exynos: Fix LAN and HUB after bootloader initialization on Odroid U3 .../pwrseq/pwrseq-emmc.txt} | 0 .../pwrseq/pwrseq-simple.txt} | 29 +++- MAINTAINERS | 9 ++ arch/arm/boot/dts/exynos4412-odroidu3.dts | 5 + drivers/mmc/Kconfig | 2 - drivers/mmc/core/Makefile | 3 - drivers/mmc/core/core.c | 8 +- drivers/mmc/core/host.c | 2 +- drivers/mmc/core/pwrseq.c | 110 --------------- drivers/mmc/core/pwrseq.h | 52 ------- drivers/power/Kconfig | 1 + drivers/power/Makefile | 1 + drivers/{mmc/core => power/pwrseq}/Kconfig | 22 ++- drivers/power/pwrseq/Makefile | 3 + drivers/power/pwrseq/pwrseq.c | 153 +++++++++++++++++++++ drivers/{mmc/core => power/pwrseq}/pwrseq_emmc.c | 17 +-- drivers/{mmc/core => power/pwrseq}/pwrseq_simple.c | 110 ++++++++++++--- drivers/usb/core/hub.c | 16 ++- drivers/usb/core/hub.h | 3 + drivers/usb/core/port.c | 15 ++ include/linux/mmc/host.h | 4 +- include/linux/pwrseq.h | 63 +++++++++ 22 files changed, 414 insertions(+), 214 deletions(-) rename Documentation/devicetree/bindings/{mmc/mmc-pwrseq-emmc.txt => power/pwrseq/pwrseq-emmc.txt} (100%) rename Documentation/devicetree/bindings/{mmc/mmc-pwrseq-simple.txt => power/pwrseq/pwrseq-simple.txt} (53%) delete mode 100644 drivers/mmc/core/pwrseq.c delete mode 100644 drivers/mmc/core/pwrseq.h rename drivers/{mmc/core => power/pwrseq}/Kconfig (60%) create mode 100644 drivers/power/pwrseq/Makefile create mode 100644 drivers/power/pwrseq/pwrseq.c rename drivers/{mmc/core => power/pwrseq}/pwrseq_emmc.c (88%) rename drivers/{mmc/core => power/pwrseq}/pwrseq_simple.c (52%) create mode 100644 include/linux/pwrseq.h -- 1.9.1