From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751244AbcFASxe (ORCPT ); Wed, 1 Jun 2016 14:53:34 -0400 Received: from mail-pf0-f177.google.com ([209.85.192.177]:36549 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751076AbcFASxd (ORCPT ); Wed, 1 Jun 2016 14:53:33 -0400 From: John Stultz To: lkml Cc: John Stultz , Mika Westerberg , Baolin Wang , Thomas Gleixner , Shuah Khan , Arnd Bergmann , Ingo Molnar , Richard Cochran , Prarit Bhargava Subject: [PATCH 0/2 v2] Fix for settimeofday() error checking regression Date: Wed, 1 Jun 2016 11:53:25 -0700 Message-Id: <1464807207-16530-1-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As reported by Mika Westerberg here: https://lkml.org/lkml/2016/5/30/413 A regression in the settimeofday error checking snuck in via 86d3473224b0 ("time: Introduce do_sys_settimeofday64()"), effecting cases where the timeval is null but the timezone was set. This patchset contains my proposed fix and an addition to the kselftests to add checks for this case. Thomas: Can you please queue the first patch in tip/timers/urgent? Shuah: I'll leave the second patch to your discretion. thanks -john v2: * Add logic simplification suggested by Dima Stepanov * Add tested by tag from Mika Cc: Mika Westerberg Cc: Baolin Wang Cc: Thomas Gleixner Cc: Shuah Khan Cc: Arnd Bergmann Cc: Ingo Molnar Cc: Richard Cochran Cc: Prarit Bhargava John Stultz (2): time: Fix problematic change in settimeofday error checking kselftests: timers: Add set-tz test case include/linux/timekeeping.h | 3 + tools/testing/selftests/timers/Makefile | 3 +- tools/testing/selftests/timers/set-tz.c | 119 ++++++++++++++++++++++++++++++++ 3 files changed, 124 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/timers/set-tz.c -- 1.9.1