All of lore.kernel.org
 help / color / mirror / Atom feed
From: <suravee.suthikulpanit@amd.com>
To: xen-devel@lists.xen.org, paul.durrant@citrix.com,
	jbeulich@suse.com, george.dunlap@citrix.com
Cc: keir@xen.org, Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
Subject: [PATCH v4 0/2] Fix xen crash when starting HVM guest due to missing io handler
Date: Wed, 1 Jun 2016 14:52:58 -0500	[thread overview]
Message-ID: <1464810780-1640-1-git-send-email-suravee.suthikulpanit@amd.com> (raw)

From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>

Hi All,

Changes from V3:
  * Remove calls to guest_iommu_init()/destroy() for now since
    the guest iommu feature is not functing and causing breakage. 
  * Do not change the ordering of the iommu_domain_init() and
    hvm_domain_init() for now until we agree on proper ordering.

OVERVIEW:
 
On systems with iommu v2 enabled, the hypervisor crashes when trying
to start up an HVM guest. 

Investigating shows that the guest_iommu_init() is called before the
HVM domain is initialized. It then tries to register_mmio_handler()
causing the hvm_next_io_handler() to increment the io_handler_count.
However, the registration fails silently and left the I/O handler
uninitialized.

At later time, hvm_find_io_handler() is called and iterate through
the registered handlered, but then resulting in referencing NULL
pointers.

This patch series proposes workaround for this issue.

Thanks,
Suravee

Suravee Suthikulpanit (2):
  AMD IOMMU: Removing currently non-functioning guest iommu feature
  x86/hvm: Add check when register io handler

 xen/arch/x86/hvm/intercept.c                | 2 ++
 xen/drivers/passthrough/amd/pci_amd_iommu.c | 4 ----
 2 files changed, 2 insertions(+), 4 deletions(-)

-- 
1.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

             reply	other threads:[~2016-06-01 19:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-01 19:52 suravee.suthikulpanit [this message]
2016-06-01 19:52 ` [PATCH v4 1/2] AMD IOMMU: Removing currently non-functioning guest iommu feature suravee.suthikulpanit
2016-06-02  8:01   ` Paul Durrant
2016-06-02  9:55   ` Jan Beulich
2016-06-02 10:26     ` Wei Liu
2016-06-02 10:43       ` Jan Beulich
2016-06-02 10:49         ` Wei Liu
2016-06-01 19:53 ` [PATCH v4 2/2] x86/hvm: Add check when register io handler suravee.suthikulpanit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464810780-1640-1-git-send-email-suravee.suthikulpanit@amd.com \
    --to=suravee.suthikulpanit@amd.com \
    --cc=george.dunlap@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=keir@xen.org \
    --cc=paul.durrant@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.