All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: kbuild-all@01.org, linux-rdma@vger.kernel.org,
	target-devel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [target:queue 6/14] drivers/target/target_core_sbc.c:384:19: error: assignment from incompatible pointer type
Date: Wed, 01 Jun 2016 13:53:29 -0700	[thread overview]
Message-ID: <1464814409.10899.1.camel@haakon3.risingtidesystems.com> (raw)
In-Reply-To: <201606011755.TDYVk6T3%fengguang.wu@intel.com>

On Wed, 2016-06-01 at 17:41 +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git queue
> head:   4d13930836b3a61c70603178d8a3c60e633e40f1
> commit: 39a54101d1cc581dbf494b0964537e795466e0d4 [6/14] target: Convert se_cmd->execute_cmd to target_iostate
> config: sh-allyesconfig (attached as .config)
> compiler: sh4-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 39a54101d1cc581dbf494b0964537e795466e0d4
>         # save the attached .config to linux build tree
>         make.cross ARCH=sh 
> 
> Note: the target/queue HEAD 4d13930836b3a61c70603178d8a3c60e633e40f1 builds fine.
>       It only hurts bisectibility.
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/target/target_core_sbc.c: In function 'sbc_setup_write_same':
> >> drivers/target/target_core_sbc.c:384:19: error: assignment from incompatible pointer type [-Werror=incompatible-pointer-types]
>      cmd->execute_cmd = ops->execute_write_same;
>                       ^
>    drivers/target/target_core_sbc.c: In function 'sbc_parse_cdb':
>    drivers/target/target_core_sbc.c:1065:21: error: assignment from incompatible pointer type [-Werror=incompatible-pointer-types]
>        cmd->execute_cmd = ops->execute_sync_cache;
>                         ^
>    cc1: some warnings being treated as errors
> 
> vim +384 drivers/target/target_core_sbc.c
> 
> cd063bef Nicholas Bellinger 2012-11-07  378  		return TCM_UNSUPPORTED_SCSI_OPCODE;
> d6e0175c Christoph Hellwig  2012-05-20  379  
> afd73f1b Nicholas Bellinger 2015-02-14  380  	ret = sbc_check_prot(dev, cmd, &cmd->t_task_cdb[0], sectors, true);
> afd73f1b Nicholas Bellinger 2015-02-14  381  	if (ret)
> afd73f1b Nicholas Bellinger 2015-02-14  382  		return ret;
> afd73f1b Nicholas Bellinger 2015-02-14  383  
> cd063bef Nicholas Bellinger 2012-11-07 @384  	cmd->execute_cmd = ops->execute_write_same;
> d6e0175c Christoph Hellwig  2012-05-20  385  	return 0;
> d6e0175c Christoph Hellwig  2012-05-20  386  }
> d6e0175c Christoph Hellwig  2012-05-20  387  
> 
> :::::: The code at line 384 was first introduced by commit
> :::::: cd063bef414c51d79b9c6ea7a8ef8f9d319529bc target/sbc: Seperate WRITE_SAME based on UNMAP flag in sbc_ops
> 
> :::::: TO: Nicholas Bellinger <nab@linux-iscsi.org>
> :::::: CC: Nicholas Bellinger <nab@linux-iscsi.org>
> 

Fixed.

Thanks Fengguang.


      reply	other threads:[~2016-06-01 20:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-01  9:41 [target:queue 6/14] drivers/target/target_core_sbc.c:384:19: error: assignment from incompatible pointer type kbuild test robot
2016-06-01 20:53 ` Nicholas A. Bellinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464814409.10899.1.camel@haakon3.risingtidesystems.com \
    --to=nab@linux-iscsi.org \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.