From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161325AbcFBOU3 (ORCPT ); Thu, 2 Jun 2016 10:20:29 -0400 Received: from lists.s-osg.org ([54.187.51.154]:39602 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161283AbcFBOU1 (ORCPT ); Thu, 2 Jun 2016 10:20:27 -0400 From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Marc Zyngier , Javier Martinez Canillas , Kukjin Kim , Seung-Woo Kim , dri-devel@lists.freedesktop.org, Inki Dae , linux-samsung-soc@vger.kernel.org, Kyungmin Park , Krzysztof Kozlowski , David Airlie , Joonyoung Shim , linux-arm-kernel@lists.infradead.org Subject: [PATCH] drm/exynos: don't use HW trigger for Exynos5420/5422/5800 Date: Thu, 2 Jun 2016 10:20:10 -0400 Message-Id: <1464877210-27207-1-git-send-email-javier@osg.samsung.com> X-Mailer: git-send-email 2.5.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit a6f75aa161c5 ("drm/exynos: fimd: add HW trigger support") added hardware trigger support to the FIMD controller driver. But this broke the display in at least the Exynos5800 Peach Pi Chromebook. So until the issue is fixed, avoid using HW trigger for the Exynos5420 based boards and use SW trigger as it was before the mentioned commit. Signed-off-by: Javier Martinez Canillas --- Hello Inki, Since commit a6f75aa161c5 landed in v4.7-rc1, I think $SUBJECT should be picked to make sure that v4.7 is released with the display working for the Exynos5420 based Chromebooks. We can then figure out what's wrong with the HW trigger support and fix it for v4.8. Best regards, Javier drivers/gpu/drm/exynos/exynos_drm_fimd.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 1c23a8ff5e83..f10030ff00e6 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -170,14 +170,11 @@ static struct fimd_driver_data exynos5420_fimd_driver_data = { .lcdblk_vt_shift = 24, .lcdblk_bypass_shift = 15, .lcdblk_mic_bypass_shift = 11, - .trg_type = I80_HW_TRG, .has_shadowcon = 1, .has_vidoutcon = 1, .has_vtsel = 1, .has_mic_bypass = 1, .has_dp_clk = 1, - .has_hw_trigger = 1, - .has_trigger_per_te = 1, }; struct fimd_context { -- 2.5.5 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: [PATCH] drm/exynos: don't use HW trigger for Exynos5420/5422/5800 Date: Thu, 2 Jun 2016 10:20:10 -0400 Message-ID: <1464877210-27207-1-git-send-email-javier@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Marc Zyngier , Seung-Woo Kim , dri-devel@lists.freedesktop.org, Javier Martinez Canillas , Kyungmin Park , Kukjin Kim , linux-arm-kernel@lists.infradead.org List-Id: linux-samsung-soc@vger.kernel.org Q29tbWl0IGE2Zjc1YWExNjFjNSAoImRybS9leHlub3M6IGZpbWQ6IGFkZCBIVyB0cmlnZ2VyIHN1 cHBvcnQiKSBhZGRlZApoYXJkd2FyZSB0cmlnZ2VyIHN1cHBvcnQgdG8gdGhlIEZJTUQgY29udHJv bGxlciBkcml2ZXIuIEJ1dCB0aGlzIGJyb2tlCnRoZSBkaXNwbGF5IGluIGF0IGxlYXN0IHRoZSBF eHlub3M1ODAwIFBlYWNoIFBpIENocm9tZWJvb2suCgpTbyB1bnRpbCB0aGUgaXNzdWUgaXMgZml4 ZWQsIGF2b2lkIHVzaW5nIEhXIHRyaWdnZXIgZm9yIHRoZSBFeHlub3M1NDIwCmJhc2VkIGJvYXJk cyBhbmQgdXNlIFNXIHRyaWdnZXIgYXMgaXQgd2FzIGJlZm9yZSB0aGUgbWVudGlvbmVkIGNvbW1p dC4KClNpZ25lZC1vZmYtYnk6IEphdmllciBNYXJ0aW5leiBDYW5pbGxhcyA8amF2aWVyQG9zZy5z YW1zdW5nLmNvbT4KCi0tLQoKSGVsbG8gSW5raSwKClNpbmNlIGNvbW1pdCBhNmY3NWFhMTYxYzUg bGFuZGVkIGluIHY0LjctcmMxLCBJIHRoaW5rICRTVUJKRUNUIHNob3VsZCBiZQpwaWNrZWQgdG8g bWFrZSBzdXJlIHRoYXQgdjQuNyBpcyByZWxlYXNlZCB3aXRoIHRoZSBkaXNwbGF5IHdvcmtpbmcg Zm9yCnRoZSBFeHlub3M1NDIwIGJhc2VkIENocm9tZWJvb2tzLgoKV2UgY2FuIHRoZW4gZmlndXJl IG91dCB3aGF0J3Mgd3Jvbmcgd2l0aCB0aGUgSFcgdHJpZ2dlciBzdXBwb3J0IGFuZCBmaXgKaXQg Zm9yIHY0LjguCgpCZXN0IHJlZ2FyZHMsCkphdmllcgoKIGRyaXZlcnMvZ3B1L2RybS9leHlub3Mv ZXh5bm9zX2RybV9maW1kLmMgfCAzIC0tLQogMSBmaWxlIGNoYW5nZWQsIDMgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2ZpbWQuYyBi L2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RybV9maW1kLmMKaW5kZXggMWMyM2E4ZmY1 ZTgzLi5mMTAwMzBmZjAwZTYgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5 bm9zX2RybV9maW1kLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2Zp bWQuYwpAQCAtMTcwLDE0ICsxNzAsMTEgQEAgc3RhdGljIHN0cnVjdCBmaW1kX2RyaXZlcl9kYXRh IGV4eW5vczU0MjBfZmltZF9kcml2ZXJfZGF0YSA9IHsKIAkubGNkYmxrX3Z0X3NoaWZ0ID0gMjQs CiAJLmxjZGJsa19ieXBhc3Nfc2hpZnQgPSAxNSwKIAkubGNkYmxrX21pY19ieXBhc3Nfc2hpZnQg PSAxMSwKLQkudHJnX3R5cGUgPSBJODBfSFdfVFJHLAogCS5oYXNfc2hhZG93Y29uID0gMSwKIAku aGFzX3ZpZG91dGNvbiA9IDEsCiAJLmhhc192dHNlbCA9IDEsCiAJLmhhc19taWNfYnlwYXNzID0g MSwKIAkuaGFzX2RwX2NsayA9IDEsCi0JLmhhc19od190cmlnZ2VyID0gMSwKLQkuaGFzX3RyaWdn ZXJfcGVyX3RlID0gMSwKIH07CiAKIHN0cnVjdCBmaW1kX2NvbnRleHQgewotLSAKMi41LjUKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: javier@osg.samsung.com (Javier Martinez Canillas) Date: Thu, 2 Jun 2016 10:20:10 -0400 Subject: [PATCH] drm/exynos: don't use HW trigger for Exynos5420/5422/5800 Message-ID: <1464877210-27207-1-git-send-email-javier@osg.samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Commit a6f75aa161c5 ("drm/exynos: fimd: add HW trigger support") added hardware trigger support to the FIMD controller driver. But this broke the display in at least the Exynos5800 Peach Pi Chromebook. So until the issue is fixed, avoid using HW trigger for the Exynos5420 based boards and use SW trigger as it was before the mentioned commit. Signed-off-by: Javier Martinez Canillas --- Hello Inki, Since commit a6f75aa161c5 landed in v4.7-rc1, I think $SUBJECT should be picked to make sure that v4.7 is released with the display working for the Exynos5420 based Chromebooks. We can then figure out what's wrong with the HW trigger support and fix it for v4.8. Best regards, Javier drivers/gpu/drm/exynos/exynos_drm_fimd.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 1c23a8ff5e83..f10030ff00e6 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -170,14 +170,11 @@ static struct fimd_driver_data exynos5420_fimd_driver_data = { .lcdblk_vt_shift = 24, .lcdblk_bypass_shift = 15, .lcdblk_mic_bypass_shift = 11, - .trg_type = I80_HW_TRG, .has_shadowcon = 1, .has_vidoutcon = 1, .has_vtsel = 1, .has_mic_bypass = 1, .has_dp_clk = 1, - .has_hw_trigger = 1, - .has_trigger_per_te = 1, }; struct fimd_context { -- 2.5.5