All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com,
	Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	jsnow@redhat.com, qemu-block@nongnu.org, mreitz@redhat.com
Subject: [Qemu-devel] [PATCH v5 06/10] block: Assert that bdrv_release_dirty_bitmap succeeded
Date: Fri,  3 Jun 2016 12:32:58 +0800	[thread overview]
Message-ID: <1464928382-9650-7-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1464928382-9650-1-git-send-email-famz@redhat.com>

We use a loop over bs->dirty_bitmaps to make sure the caller is
only releasing a bitmap owned by bs. Let's also assert that in this case
the caller is releasing a bitmap that does exist.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 block/dirty-bitmap.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
index a71c9b7..39e072a 100644
--- a/block/dirty-bitmap.c
+++ b/block/dirty-bitmap.c
@@ -305,6 +305,9 @@ static void bdrv_do_release_matching_dirty_bitmap(BlockDriverState *bs,
             }
         }
     }
+    if (bitmap) {
+        abort();
+    }
 }
 
 void bdrv_release_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap *bitmap)
-- 
2.8.2

  parent reply	other threads:[~2016-06-03  4:33 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-03  4:32 [Qemu-devel] [PATCH v5 00/10] Dirty bitmap changes for migration/persistence work Fam Zheng
2016-06-03  4:32 ` [Qemu-devel] [PATCH v5 01/10] block: Hide HBitmap in block dirty bitmap interface Fam Zheng
2016-06-22 15:10   ` Max Reitz
2016-06-28 15:36   ` Vladimir Sementsov-Ogievskiy
2016-06-28 15:39     ` Vladimir Sementsov-Ogievskiy
2016-07-12 22:49   ` John Snow
2016-07-13  7:57     ` Vladimir Sementsov-Ogievskiy
2016-07-13 10:10       ` Max Reitz
2016-06-03  4:32 ` [Qemu-devel] [PATCH v5 02/10] HBitmap: Introduce "meta" bitmap to track bit changes Fam Zheng
2016-06-22 15:22   ` Max Reitz
2016-07-13 17:39     ` John Snow
2016-06-03  4:32 ` [Qemu-devel] [PATCH v5 03/10] tests: Add test code for meta bitmap Fam Zheng
2016-06-22 15:30   ` Max Reitz
2016-06-03  4:32 ` [Qemu-devel] [PATCH v5 04/10] block: Support meta dirty bitmap Fam Zheng
2016-06-22 15:53   ` Max Reitz
2016-07-14 20:00     ` John Snow
2016-07-15 12:04       ` Max Reitz
2016-07-15 12:10         ` Max Reitz
2016-07-18  6:59           ` Fam Zheng
2016-07-15 18:02         ` John Snow
2016-06-03  4:32 ` [Qemu-devel] [PATCH v5 05/10] block: Add two dirty bitmap getters Fam Zheng
2016-06-22 16:02   ` Max Reitz
2016-06-03  4:32 ` Fam Zheng [this message]
2016-06-22 16:08   ` [Qemu-devel] [PATCH v5 06/10] block: Assert that bdrv_release_dirty_bitmap succeeded Max Reitz
2016-06-03  4:32 ` [Qemu-devel] [PATCH v5 07/10] hbitmap: serialization Fam Zheng
2016-06-28 14:15   ` Vladimir Sementsov-Ogievskiy
2016-07-14 20:45     ` John Snow
2016-06-03  4:33 ` [Qemu-devel] [PATCH v5 08/10] block: BdrvDirtyBitmap serialization interface Fam Zheng
2016-06-03  4:33 ` [Qemu-devel] [PATCH v5 09/10] tests: Add test code for hbitmap serialization Fam Zheng
2016-06-03  4:33 ` [Qemu-devel] [PATCH v5 10/10] block: More operations for meta dirty bitmap Fam Zheng
2016-06-03  8:53 ` [Qemu-devel] [PATCH v5 00/10] Dirty bitmap changes for migration/persistence work Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464928382-9650-7-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.