From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 00/18] lib/librte_pmd_fm10k : fm10k pmd driver Date: Fri, 30 Jan 2015 23:19:18 +0100 Message-ID: <1465014.svDMzIcz90@xps13> References: <1422594454-11045-1-git-send-email-jing.d.chen@intel.com> <20150130212633.GD2664@hmsreliant.think-freely.org> <20150130214622.GA21286@plxv1142.pdx.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Jeff Shaw Return-path: In-Reply-To: <20150130214622.GA21286-P+9LSW+heshDtcM2BRa8+1DQ4js95KgL@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-01-30 13:46, Jeff Shaw: > On Fri, Jan 30, 2015 at 04:26:33PM -0500, Neil Horman wrote: > > On Fri, Jan 30, 2015 at 01:07:16PM +0800, Chen Jing D(Mark) wrote: > > > From: "Chen Jing D(Mark)" > > > Jeff Shaw (18): > > > fm10k: add base driver [...] > > > lib/librte_pmd_fm10k/SHARED/fm10k_api.c | 327 ++++ [...] > > > > Why is there a SHARED directory in the driver? Are there other drivers that use > > the shared fm10k code? > > No, the other poll-mode drivers do not use the shared fm10k code. The > directory is similar to the 'ixgbe' and 'i40e' directories in their > respective PMDs, only that it is named 'SHARED' for the fm10k driver. So shared is a bad name in the context of DPDK. Inside Intel, it can be understood that you share it between projects, but in DPDK, it's only a base driver. -- Thomas