All of lore.kernel.org
 help / color / mirror / Atom feed
From: xiaoqiang zhao <zxq_yx_007@163.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, pbonzini@redhat.com,
	antonynpavlov@gmail.com, robh@kernel.org, qemu-arm@nongnu.org,
	edgar.iglesias@gmail.com, alistair.francis@xilinx.com,
	crosthwaite.peter@gmail.com, armbru@redhat.com
Subject: [Qemu-devel] [PATCH v2 6/6] char: get rid of qemu_char_get_next_serial
Date: Sat,  4 Jun 2016 16:14:25 +0800	[thread overview]
Message-ID: <1465028065-5855-7-git-send-email-zxq_yx_007@163.com> (raw)
In-Reply-To: <1465028065-5855-1-git-send-email-zxq_yx_007@163.com>

since there is no user of qemu_char_get_next_serial any more,
it's time to let it go away.

Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
---
 include/sysemu/char.h |  1 -
 qemu-char.c           | 16 ----------------
 2 files changed, 17 deletions(-)

diff --git a/include/sysemu/char.h b/include/sysemu/char.h
index 307fd8f..372a6fd 100644
--- a/include/sysemu/char.h
+++ b/include/sysemu/char.h
@@ -403,7 +403,6 @@ void register_char_driver(const char *name, ChardevBackendKind kind,
 
 extern int term_escape_char;
 
-CharDriverState *qemu_char_get_next_serial(void);
 
 /* console.c */
 typedef CharDriverState *(VcHandler)(ChardevVC *vc, Error **errp);
diff --git a/qemu-char.c b/qemu-char.c
index b597ee1..b13ecbb 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -4088,22 +4088,6 @@ CharDriverState *qemu_chr_find(const char *name)
     return NULL;
 }
 
-/* Get a character (serial) device interface.  */
-CharDriverState *qemu_char_get_next_serial(void)
-{
-    static int next_serial;
-    CharDriverState *chr;
-
-    /* FIXME: This function needs to go away: use chardev properties!  */
-
-    while (next_serial < MAX_SERIAL_PORTS && serial_hds[next_serial]) {
-        chr = serial_hds[next_serial++];
-        qemu_chr_fe_claim_no_fail(chr);
-        return chr;
-    }
-    return NULL;
-}
-
 QemuOptsList qemu_chardev_opts = {
     .name = "chardev",
     .implied_opt_name = "backend",
-- 
2.8.1

  parent reply	other threads:[~2016-06-04  8:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-04  8:14 [Qemu-devel] [PATCH v2 0/6] Drop the qemu_char_get_next_serial function xiaoqiang zhao
2016-06-04  8:14 ` [Qemu-devel] [PATCH v2 1/6] hw/char: QOM'ify pl011 model xiaoqiang zhao
2016-06-04  8:14 ` [Qemu-devel] [PATCH v2 2/6] hw/char: QOM'ify cadence_uart model xiaoqiang zhao
2016-06-04  8:14 ` [Qemu-devel] [PATCH v2 3/6] hw/char: QOM'ify digic-uart model xiaoqiang zhao
2016-06-04  8:14 ` [Qemu-devel] [PATCH v2 4/6] hw/char: QOM'ify stm32f2xx_usart model xiaoqiang zhao
2016-06-04  8:14 ` [Qemu-devel] [PATCH v2 5/6] hw/char: QOM'ify xilinx_uartlite model xiaoqiang zhao
2016-06-04  8:14 ` xiaoqiang zhao [this message]
2016-06-06 14:00 ` [Qemu-devel] [PATCH v2 0/6] Drop the qemu_char_get_next_serial function Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465028065-5855-7-git-send-email-zxq_yx_007@163.com \
    --to=zxq_yx_007@163.com \
    --cc=alistair.francis@xilinx.com \
    --cc=antonynpavlov@gmail.com \
    --cc=armbru@redhat.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.