All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Florian Westphal <fw@strlen.de>
Cc: David Miller <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	Stas Nichiporovich <stasn77@gmail.com>,
	WANG Cong <xiyou.wangcong@gmail.com>,
	Jamal Hadi Salim <jhs@mojatatu.com>
Subject: Re: [net] fq_codel: fix NET_XMIT_CN behavior
Date: Sat, 04 Jun 2016 12:40:32 -0700	[thread overview]
Message-ID: <1465069232.2968.14.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <20160604190301.GA8857@strlen.de>

On Sat, 2016-06-04 at 21:03 +0200, Florian Westphal wrote:

> Is skb still valid here? AFAICS its possible that fq_codel_drop() drops it.
> 
> Other than that this looks good, thanks Eric!

You are are right. skb is guaranteed to be valid only when we return
NET_XMIT_SUCCESS.

I'll send a V2, thanks !

  reply	other threads:[~2016-06-04 19:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-04 17:43 [PATCH net] fq_codel: fix NET_XMIT_CN behavior Eric Dumazet
2016-06-04 19:03 ` [net] " Florian Westphal
2016-06-04 19:40   ` Eric Dumazet [this message]
2016-06-04 19:55   ` [PATCH v2 net] " Eric Dumazet
2016-06-05 13:03     ` Jamal Hadi Salim
2016-06-05 20:30     ` Cong Wang
2016-06-05 20:54       ` Eric Dumazet
2016-06-05 20:55         ` Eric Dumazet
2016-06-05 23:30           ` Cong Wang
2016-06-06 10:49             ` Jamal Hadi Salim
2016-06-06 11:42               ` Florian Westphal
2016-06-06 14:37                 ` Eric Dumazet
2016-06-06 16:18                   ` Florian Westphal
2016-06-10 12:02                     ` Jamal Hadi Salim
2016-06-06 14:29               ` Eric Dumazet
2016-06-07 22:39     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465069232.2968.14.camel@edumazet-glaptop3.roam.corp.google.com \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=fw@strlen.de \
    --cc=jhs@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=stasn77@gmail.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.