From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756175AbcFGRtn (ORCPT ); Tue, 7 Jun 2016 13:49:43 -0400 Received: from 82-70-136-246.dsl.in-addr.zen.co.uk ([82.70.136.246]:37082 "EHLO rainbowdash.ducie.codethink.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756110AbcFGRtl (ORCPT ); Tue, 7 Jun 2016 13:49:41 -0400 From: Ben Dooks To: linux-kernel@lists.codethink.co.uk Cc: Ben Dooks , Eric Anholt , Ulf Hansson , Alexander Aring , Kevin Hilman , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] ARM: bcm2835: remove unused __packet Date: Tue, 7 Jun 2016 18:49:33 +0100 Message-Id: <1465321773-21519-1-git-send-email-ben.dooks@codethink.co.uk> X-Mailer: git-send-email 2.8.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver defines a variable called __packet but then never uses it, and does not export it for others to use either. Fix the warning about undeclared variable by removing it. drivers/soc/bcm/raspberrypi-power.c:48:3: warning: symbol '__packet' was not declared. Should it be static? Signed-off-by: Ben Dooks --- Cc: Eric Anholt Cc: Ulf Hansson Cc: Alexander Aring Cc: Kevin Hilman Cc: linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org --- drivers/soc/bcm/raspberrypi-power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/bcm/raspberrypi-power.c b/drivers/soc/bcm/raspberrypi-power.c index fe96a8b..f7ed118 100644 --- a/drivers/soc/bcm/raspberrypi-power.c +++ b/drivers/soc/bcm/raspberrypi-power.c @@ -45,7 +45,7 @@ struct rpi_power_domains { struct rpi_power_domain_packet { u32 domain; u32 on; -} __packet; +}; /* * Asks the firmware to enable or disable power on a specific power -- 2.8.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: ben.dooks@codethink.co.uk (Ben Dooks) Date: Tue, 7 Jun 2016 18:49:33 +0100 Subject: [PATCH] ARM: bcm2835: remove unused __packet Message-ID: <1465321773-21519-1-git-send-email-ben.dooks@codethink.co.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org The driver defines a variable called __packet but then never uses it, and does not export it for others to use either. Fix the warning about undeclared variable by removing it. drivers/soc/bcm/raspberrypi-power.c:48:3: warning: symbol '__packet' was not declared. Should it be static? Signed-off-by: Ben Dooks --- Cc: Eric Anholt Cc: Ulf Hansson Cc: Alexander Aring Cc: Kevin Hilman Cc: linux-kernel at vger.kernel.org Cc: linux-arm-kernel at lists.infradead.org --- drivers/soc/bcm/raspberrypi-power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/bcm/raspberrypi-power.c b/drivers/soc/bcm/raspberrypi-power.c index fe96a8b..f7ed118 100644 --- a/drivers/soc/bcm/raspberrypi-power.c +++ b/drivers/soc/bcm/raspberrypi-power.c @@ -45,7 +45,7 @@ struct rpi_power_domains { struct rpi_power_domain_packet { u32 domain; u32 on; -} __packet; +}; /* * Asks the firmware to enable or disable power on a specific power -- 2.8.1